-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datepicker crashes with non-standard time intervals - still an issue #2262
Comments
saltire
added a commit
to saltire/react-datepicker
that referenced
this issue
Aug 21, 2020
…01#2262) Centers the time window on the nearest time before or equal to the active time, regardless of its hour.
saltire
added a commit
to saltire/react-datepicker
that referenced
this issue
Aug 21, 2020
…01#2262) Centers the time window on the nearest time before or equal to the active time, regardless of its hour.
martijnrusschen
pushed a commit
that referenced
this issue
Aug 22, 2020
Hey, thanks for merging my PR. Any idea when we'll see a release? |
p-rogas
pushed a commit
to p-rogas/react-datepicker
that referenced
this issue
Mar 22, 2023
…01#2262) (Hacker0x01#2350) Centers the time window on the nearest time before or equal to the active time, regardless of its hour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Same as #2169 - although a fix has been merged, it's still possible to get this error in v3.1.3.
To Reproduce
Steps to reproduce the behavior:
timeIntervals={90}
July 13, 2020 2:59 PM
.TypeError: t is undefined
(Firefox),TypeError: Cannot read property 'offsetTop' of undefined
(Chrome), orTypeError: undefined is not an object (evaluating 't.offsetTop')
(Safari).Expected behavior
The calendar should appear, allowing the user to select a time at a 90-minute interval, regardless of the currently selected time.
Desktop (please complete the following information):
Additional context
It happens at many different combinations of
timeIntervals
andselected
. Here's a test fortimepicker_test.js
that triggers the error in v3.1.3:The text was updated successfully, but these errors were encountered: