Performance improvements to raw view loading #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a property to the mask manager that we can use to determine whether or not there are border-only masks present. If there are border-only masks present, then the display images and computed images will be different, so we will have to re-create the computed images from scratch. If there are no border-only masks, then the display images and the computed images are the same, and we can skip that extra computation step by re-using the display images as the computed images. Signed-off-by: Patrick Avery <[email protected]>
This was a little time consuming to do. Skip it if there are no overlays. Signed-off-by: Patrick Avery <[email protected]>
This is to avoid creating the images_dict a second time, which can be time consuming. Now we pass it in as an argument. Signed-off-by: Patrick Avery <[email protected]>
psavery
commented
Mar 28, 2024
psavery
commented
Mar 28, 2024
bnmajor
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make scrolling through images in the raw view faster, this PR provides several speed improvements to raw view loading. On my computer, it is now about 3.2x faster if there are no display masks and no overlays. Here are the performance improvements: