Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to stitch ROI images in raw view #1655

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Conversation

psavery
Copy link
Collaborator

@psavery psavery commented Jan 25, 2024

If the instrument config contains both the roi and group key in each detector, an additional checkbox now appears in the raw view settings that allows users to stitch the ROI images together.

Each subpanel is still treated separately. Overlays are also generated separately for each subpanel. However, the final images are stitched together into one large panel.

Fixes: #1627

@psavery psavery requested a review from bnmajor January 25, 2024 18:58
@pep8speaks
Copy link

pep8speaks commented Jan 25, 2024

Hello @psavery! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-01-26 19:45:11 UTC

If the instrument config contains both the `roi` and `group` key
in each detector, an additional checkbox now appears in the raw view
settings that allows users to stitch the ROI images together.

Each subpanel is still treated separately. Overlays are also generated
separately for each subpanel. However, the final images are stitched
together into one large panel.

Signed-off-by: Patrick Avery <[email protected]>
Copy link
Collaborator

@bnmajor bnmajor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!

@psavery psavery merged commit c7f1f15 into master Jan 26, 2024
9 checks passed
@psavery psavery deleted the roi-stitch-images branch January 26, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to stitch ROI images together in raw view
3 participants