Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Llnl template bugs #1303

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Llnl template bugs #1303

merged 2 commits into from
Oct 21, 2022

Conversation

bnmajor
Copy link
Collaborator

@bnmajor bnmajor commented Oct 21, 2022

Partially Fixes #1302, but the gist of #1300 is still unresolved.

@bnmajor bnmajor requested a review from joelvbernier October 21, 2022 15:34
@bnmajor bnmajor force-pushed the llnl-template-bugs branch from 90e969c to 6c9935c Compare October 21, 2022 15:55
@joelvbernier
Copy link
Member

Looks like it resolves the polygon part, but the disappearing outline on the mouse rotate after "Add Transform" remains... Some consolation, is that even though the outline disappears, it seems to still be doing the right thing. Arrow keys work fine, making it even more bizarre!

Prevents the bug where the template has a line connecting the outline to the
inner circle after a transform. Specifically occurs for the TARDIS instrument.

Signed-off-by: Brianna Major <[email protected]>
Signed-off-by: Brianna Major <[email protected]>
@bnmajor bnmajor force-pushed the llnl-template-bugs branch from 6c9935c to 56705a5 Compare October 21, 2022 17:33
@joelvbernier joelvbernier merged commit 39bc728 into HEXRD:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlay badness in LLNL Import Tool
2 participants