Clear unaggregated images also during images clear #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were not clearing unaggregated images in `HexrdConfig().clear_images()`. Clear them as well so that all of the images data is fully cleared. This issue resulted in a bug where, if you had an aggregated image series loaded, and then you loaded a new instrument config, the unaggregated images would be used and would have extra incorrect detectors in it. The unaggregated images are only used if an aggregated image series is loaded, in order to make a backup of the unaggregated images. Signed-off-by: Patrick Avery <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were not clearing unaggregated images in
HexrdConfig().clear_images(). Clear them as well so that all of theimages data is fully cleared.
This issue resulted in a bug where, if you had an aggregated image series
loaded, and then you loaded a new instrument config, the unaggregated images
would be used and would have extra incorrect detectors in it.
The unaggregated images are only used if an aggregated image series is loaded,
in order to make a backup of the unaggregated images.
See the bug here:
images_bug.mp4
And see it fixed with this PR here:
images_bug_fixed.mp4