Fix non-responding widgets for multiple indexing runs #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous design pattern created a list of `QSignalBlocker` objects, and it relied on Python to perform reference counting and delete this list at the end of the function, so that the widgets would become unblocked. For some reason, if you run indexing multiple times, it appears that this list is sometimes not deleted at the end of the function. Instead of relying on Python to perform reference counting correctly, let's use a context manager so that we can be sure the widgets get unblocked. This fixes an issue where widgets were not emitting signals in the eta omega maps viewer when running the HEDM workflow multiple times. We should also go back and fix any other cases of the design pattern, since it appears to be error-prone. Signed-off-by: Patrick Avery <[email protected]>
It appears that we can't always rely on python's reference counting system to delete `QSignalBlocker` (or lists of `QSignalBlocker`) at the end of method calls. As such, we should convert over to using the `block_signals()` context manager from `hexrd.ui.utils`. This commit moves all code over to that. Signed-off-by: Patrick Avery <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous design pattern created a list of
QSignalBlockerobjects,and it relied on Python to perform reference counting and delete this list
at the end of the function, so that the widgets would become unblocked.
For some reason, if you run indexing multiple times, it appears that this
list is sometimes not deleted at the end of the function.
Instead of relying on Python to perform reference counting correctly,
let's use a context manager so that we can be sure the widgets get
unblocked.
This fixes an issue where widgets were not emitting signals in the eta
omega maps viewer when running the HEDM workflow multiple times.
We should also go back and fix any other cases of the design pattern, since
it appears to be error-prone.