A few overlay fixes #1184
Merged
A few overlay fixes #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so that the name text will be updated. Signed-off-by: Patrick Avery <[email protected]>
This id() is being used in the image canvas to keep track of which overlay artists belong to which data dicts. As such, do not allow the id() of the dict to change by replacing the old `_data` with a new one. Instead, update the old one in place. Signed-off-by: Patrick Avery <[email protected]>
It wasn't very aesthetically pleasing when it would not stretch like it was supposed to. This would happen, for instance, when we changed the type of an overlay. Force it to do so manually. Signed-off-by: Patrick Avery <[email protected]>
This was causing a bug when copying the materials in the materials list editor, because the copy of the material was given a new name, but the name on the material object itself did not match. This means that places where the name on the material object itself was used (such as the reflections table) would be used incorrectly. Fix this by forcing newly added materials to have the name that matches their key in the dict. Signed-off-by: Patrick Avery <[email protected]>
It was previously not being updated like it should have been. Signed-off-by: Patrick Avery <[email protected]>
joelvbernier
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains a few fixes:
More details can be read in their commit messages.
Fixes: #1182
Fixes: #1183