Catch IndexError on mouse move #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error would happen occasionally in the cartesian and polar views when the mouse is moved close to an edge of the canvas. It appears that it was happening because the x_data for the event was slightly over the max, which led to an out-of-bounds index being computed. This would then result in an IndexError. This error is relatively harmless, but it may worry users, so catch it to prevent it from appearing. Signed-off-by: Patrick Avery <[email protected]>
bnmajor
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error would happen occasionally in the cartesian and polar views
when the mouse is moved close to an edge of the canvas. It appears that
it was happening because the x_data for the event was slightly over the
max, which led to an out-of-bounds index being computed. This would
then result in an IndexError.
This error is relatively harmless, but it may worry users, so catch it
to prevent it from appearing.
I believe this error has been happening more commonly for me after #1138 was merged.