Support python 3.12, update lxml to 5.x #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgaul3
approved these changes
Jun 7, 2024
|
@ojii Can I just create a new release after merging this? |
|
@FurqanHabibi this probably also needs an update to https://github.com/HENNGE/minisignxml (if you want some scope creep: these two repos should probably be merged into a 'monorepo', though still keeping the two packages separate on pypi) |
|
Let me just add pypi release GHA to both repos and think about merging them later 🙏 |
y26805
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed support for python 3.7 since poetry requires 3.8+.
Closes #27