Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap more error responses #70

Open
dimaqq opened this issue Mar 2, 2021 · 4 comments
Open

Wrap more error responses #70

dimaqq opened this issue Mar 2, 2021 · 4 comments

Comments

@dimaqq
Copy link
Contributor

dimaqq commented Mar 2, 2021

For example, ResourceInUseException (e.g. trying to create a table that already exists)

Today the error is aiodynamo.errors.UnknownError: b'{"__type":"com.amazonaws.dynamodb.v20120810#ResourceInUseException","message":""}'

@flpStrri
Copy link

flpStrri commented Oct 4, 2021

@dimaqq, do you have a list of errors that we should wrap here? I can help with this one.

@dimaqq
Copy link
Contributor Author

dimaqq commented Oct 5, 2021

Awesome, João!

This particular error we've observed in production, and a bunch are already handled.
I don't know if there's an authoritative list of all possible errors that ddb can throw at us 🙈

dynalite implements [most of] dynamodb protocol, and since it's open source, we should probably support all the errors it produces: https://github.com/mhart/dynalite/search?q=__type

Official list is here: https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/Programming.Errors.html

@flpStrri
Copy link

flpStrri commented Oct 5, 2021

Sure! I will check both of this resources and put my fingers to work. Also, how small are the PRs here? I should push one by PR, one PR with each error in a commit, pack them all?

@dimaqq
Copy link
Contributor Author

dimaqq commented Oct 5, 2021

all in one is just fine :)

dimaqq added a commit that referenced this issue Nov 17, 2021
For #70 

`ResourceInUseException` is returned when trying to create a table that already exists... (maybe the assumption is that table is being used right now).
ran into this with `dynalite`.
dimaqq added a commit that referenced this issue Nov 26, 2021
For #70 

`ResourceInUseException` is returned when trying to create a table that already exists... (maybe the assumption is that table is being used right now).
ran into this with `dynalite`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants