Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support time() and related functions in PromQL #2854

Merged
merged 9 commits into from
Dec 4, 2023

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Dec 1, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • Enhance support of time()
  • Add support to
    • minute()
    • hour
    • month()
    • year()
    • day_of_month()
    • day_of_week()
    • day_of_year()
    • days_in_month()

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #2854 (e588192) into develop (7e68ecc) will decrease coverage by 0.31%.
Report is 5 commits behind head on develop.
The diff coverage is 48.14%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2854      +/-   ##
===========================================
- Coverage    84.62%   84.31%   -0.31%     
===========================================
  Files          738      740       +2     
  Lines       115520   116498     +978     
===========================================
+ Hits         97755    98225     +470     
- Misses       17765    18273     +508     

Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
@waynexia waynexia requested a review from killme2008 December 4, 2023 08:15
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
@killme2008 killme2008 added this pull request to the merge queue Dec 4, 2023
Merged via the queue into GreptimeTeam:develop with commit de41646 Dec 4, 2023
13 checks passed
@waynexia waynexia deleted the prom-time-fn branch December 8, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants