-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support unary, paren, bool keyword and nonexistent metric/label in PromQL #1049
Conversation
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #1049 +/- ##
===========================================
- Coverage 85.81% 85.71% -0.11%
===========================================
Files 444 446 +2
Lines 64568 64897 +329
===========================================
+ Hits 55411 55628 +217
- Misses 9157 9269 +112
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… in PromQL (GreptimeTeam#1049) * feat: don't report metric/label not found as error Signed-off-by: Ruihang Xia <[email protected]> * feat: impl unary expr Signed-off-by: Ruihang Xia <[email protected]> * feat: impl paren expr Signed-off-by: Ruihang Xia <[email protected]> * feat: support bool keyword Signed-off-by: Ruihang Xia <[email protected]> * add some tests Signed-off-by: Ruihang Xia <[email protected]> * ignore nonexistence labels during planning Signed-off-by: Ruihang Xia <[email protected]> * fix clippy Signed-off-by: Ruihang Xia <[email protected]> --------- Signed-off-by: Ruihang Xia <[email protected]>
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
some_metric > bool 1
)-some_metric
)(some_metric)
)Checklist
Refer to a related PR or issue link (optional)
Part of #1042