Use JLL for library on > 1.3

[samuelpowell]

No description provided.

[codecov]

Codecov Report

Merging #54 into master will decrease coverage by 0.1%.
The diff coverage is 95.65%.

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage   68.64%   68.53%   -0.11%     
==========================================
  Files           3        3              
  Lines         236      232       -4     
==========================================
- Hits          162      159       -3     
+ Misses         74       73       -1

Impacted Files	Coverage Δ
src/wrapper.jl	79.31% <95.65%> (+0.14%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10d06e9...8658b86. Read the comment docs.

[samuelpowell]

Stalled pending upstream fix JuliaPackaging/BinaryBuilder.jl#672

[giordano]

I just realised registration failed 😞 I'm going to rerun it

[samuelpowell]

Thanks @giordano yes I only just realised that +1 never made it to BinaryWrappers

[samuelpowell]

@ReubenHill can you check okay on Windows?

[ReubenHill]

Can't clone and dev or add on windows:

(hivedevtest) pkg> add LibFTD2XX#jll
  Updating registry at `C:\Users\Reuben\.julia\registries\General`
┌ Warning: Some registries failed to update:
│     — `C:\Users\Reuben\.julia\registries\General` — registry dirty
└ @ Pkg.Types D:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.3\Pkg\src\Types.jl:1199
   Cloning git-repo `https://github.com/Gowerlabs/LibFTD2XX.jl.git`
  Updating git-repo `https://github.com/Gowerlabs/LibFTD2XX.jl.git`
 Resolving package versions...
ERROR: Unsatisfiable requirements detected for package libftd2xx_jll [66e46913]:
 libftd2xx_jll [66e46913] log:
 ├─libftd2xx_jll [66e46913] has no known versions!
 └─restricted to versions 1 by LibFTD2XX [85e77ee8] — no versions left
   └─LibFTD2XX [85e77ee8] log:
     ├─possible versions are: 0.3.0 or uninstalled
     └─LibFTD2XX [85e77ee8] is fixed to version 0.3.0

[samuelpowell]

You have a dirty registry

│     — `C:\Users\Reuben\.julia\registries\General` — registry dirty

[samuelpowell]

Also need to be on >=1.3 (maybe try 1.3.1 to be sure)

[giordano]

You probably checked out a branch of the General registry, you may want to go back to master

[samuelpowell]

Any luck @ReubenHill ?

[ReubenHill]

All tests pass on windows and I see you've fixed an old mistake I'd made in FT_DEVICE_LIST_INFO_NODE. I see you've changed to hard definitions of DWORD and UCHAR. Has this been tested on ARM?

[ReubenHill]

No idea what was wrong with my registry - it had somehow got completely fiddled with

[samuelpowell]

Well, just firmed them up to match the tech reference. No tests on ARM but its the same library and it works on Linux so I can't envisage any issues.

[giordano]

You can use drone (https://discourse.julialang.org/t/testing-on-arm-with-drone-ci/25871) to test on 32- and 64-bit arm architectures, or Travis for 64-bit arm only (https://discourse.julialang.org/t/julia-aarch64-builds-are-now-available-on-travis-ci/29970)

[samuelpowell]

We have Travis for Aarch64, but on all Linux the library doesn't pass tests - its a serial port driver and talks to the kernel so I think it makes CI unhappy.

[samuelpowell]

(we have tests which run them there isn't any hardware, but even these want to try and enumerate devices, etc., with knowledge nothing will be found)