Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#2229): dropdown height issue #2295

Draft
wants to merge 1 commit into
base: alpha
Choose a base branch
from

Conversation

syedszeeshan
Copy link
Collaborator

@syedszeeshan syedszeeshan commented Dec 5, 2024

Before (the change)

image

After (the change)

image

Make sure that you've checked the boxes below before you submit the PR

  • I have read and followed the setup steps
  • I have created necessary unit tests
  • I have tested the functionality in both React and Angular.

Steps needed to test

@syedszeeshan syedszeeshan changed the title NOT READY - fix(#2229): dropdown height issue fix(#2229): dropdown height issue Dec 5, 2024
@ArakTaiRoth
Copy link
Collaborator

@syedszeeshan There appears to still be a slight discrepancy, tested in Angular with the following code:

<h2>What is your date of birth?</h2>
<goa-block>
  <goa-form-item label="Day">
    <goa-input width="50px" />
  </goa-form-item>
  <goa-form-item label="Month">
    <goa-dropdown>
      <goa-dropdown-item value="January" label="January" />
      <goa-dropdown-item value="February" label="February" />
      <goa-dropdown-item value="March" label="March" />
      <goa-dropdown-item value="April" label="April" />
      <goa-dropdown-item value="May" label="May" />
      <goa-dropdown-item value="June" label="June" />
      <goa-dropdown-item value="July" label="July" />
      <goa-dropdown-item value="August" label="August" />
      <goa-dropdown-item value="September" label="September" />
      <goa-dropdown-item value="October" label="October" />
      <goa-dropdown-item value="November" label="November" />
      <goa-dropdown-item value="December" label="December" />
    </goa-dropdown>
  </goa-form-item>
  <goa-form-item label="Year">
    <goa-input width="100px" />
  </goa-form-item>
</goa-block>

image
image

@syedszeeshan
Copy link
Collaborator Author

syedszeeshan commented Dec 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown: slightly smaller than other inputs, should be the same height
2 participants