Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public form updates #2213

Draft
wants to merge 13 commits into
base: alpha
Choose a base branch
from
Draft

Public form updates #2213

wants to merge 13 commits into from

Conversation

chrisolsen
Copy link
Collaborator

@chrisolsen chrisolsen commented Oct 23, 2024

Before (the change)

After (the change)

Make sure that you've checked the boxes below before you submit the PR

  • I have read and followed the setup steps
  • I have created necessary unit tests
  • I have tested the functionality in both React and Angular.

Steps needed to test

  • Checkbox
  • Datepicker with type set to both calendar and input
  • FormItem
  • RadioGroup

To test the playground files you will need to start at http:localhost:4200/fsos

This will prevent issues when embedded form are added
Having the internal _inputDate value contain numberic values resulted in
the initial values being displayed when no date was set.
@ArakTaiRoth ArakTaiRoth linked an issue Nov 18, 2024 that may be closed by this pull request
@lizhuomeng71
Copy link
Collaborator

Title:
Input value persists on the summary page after associated reveal checkbox is unchecked

Description:
When input values are entered in the fields revealed by the "Add Cost Amounts" checkbox, and the checkbox is later unchecked, the input values still appear on the summary page after clicking "Continue."

Steps to Reproduce:

Open the Angular application.
Navigate to Playground / FSOS.
Click on Support Order Details.
Check the Add Cost Amounts checkbox.
Enter some values into Amount One and Amount Two.
Uncheck the Add Cost Amounts checkbox.
Click Continue.
Expected Result:
The input values for Amount One and Amount Two should be cleared or ignored and should not appear on the summary page.

Actual Result:
The input values for Amount One and Amount Two still appear on the summary page, even though the checkbox was unchecked.

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants