[Major release] Angular wrappers and React name changed #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanessatran-ddi
requested review from
chrisolsen,
ArakTaiRoth and
syedszeeshan
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
vanessatran-ddi
force-pushed
the
angular-components
branch
from
c21789b to
81bb079
Compare
vanessatran-ddi
force-pushed
the
angular-components
branch
from
21f8190 to
444975f
Compare
vanessatran-ddi
changed the title
vanessatran-ddi
force-pushed
the
angular-components
branch
3 times, most recently
from
94b91fd to
bd9c6e0
Compare
chrisolsen
reviewed
Sep 9, 2024
vanessatran-ddi
force-pushed
the
angular-components
branch
4 times, most recently
from
4c9c608 to
4527899
Compare
vanessatran-ddi
force-pushed
the
angular-components
branch
from
4527899 to
e32cdd4
Compare
vanessatran-ddi
commented
Sep 16, 2024
chrisolsen
reviewed
Sep 17, 2024
vanessatran-ddi
force-pushed
the
angular-components
branch
2 times, most recently
from
616dfcf to
e32cdd4
Compare
chrisolsen
previously approved these changes
Sep 17, 2024
vanessatran-ddi
force-pushed
the
angular-components
branch
from
bd74320 to
75d59ff
Compare
vanessatran-ddi
force-pushed
the
angular-components
branch
3 times, most recently
from
b55025c to
ff2fd5a
Compare
vanessatran-ddi
force-pushed
the
angular-components
branch
2 times, most recently
from
edeee57 to
766feaf
Compare
BREAKING CHANGE: new angular components for Angular apps.
BREAKING CHANGE: rename all components for React apps.
vanessatran-ddi
force-pushed
the
angular-components
branch
3 times, most recently
from
2398b31 to
05eaea2
Compare
vanessatran-ddi
force-pushed
the
angular-components
branch
from
05eaea2 to
482df85
Compare
chrisolsen
reviewed
Dec 11, 2024
Comment on lines
187
to
189
| <slot> | ||
| {text} | ||
| </slot> |
There was a problem hiding this comment.
This could be a breaking change
There was a problem hiding this comment.
Yes I put it back
<div class="text" data-testid="text">
<slot></slot>
{text}
</div>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this drafted pull request to compare/update with
alphabranch.