Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

svelte preprocess replacemement off breakpoint tokens #1374

Merged
merged 1 commit into from
Oct 5, 2023
Merged

svelte preprocess replacemement off breakpoint tokens #1374

merged 1 commit into from
Oct 5, 2023

Conversation

chrisolsen
Copy link
Collaborator

@chrisolsen chrisolsen commented Sep 20, 2023 •
edited
Loading

This PR allows for breakpoints to be defined in one place (breakpoints.css). Along with this change all the existing breakpoints within the web-components have been updated to use the newly defined tokens.

Note: Previous the breakpoints varied throughout the components i.e. mobile breakpoint ranged from 320px to 640px, but is now set to 624px

Testing required:

  • Ensure that components that changed styles based on browser width, still do so with these changes.

@Radha-Alberta
Copy link
Contributor

Radha-Alberta commented Sep 22, 2023 •
edited
Loading

  • Issue-1: Button Width changed on Mobile Screens
  • Issue-2: Button Group Width changed on Mobile Screens
  • Issue-3: File Upload UI Mobile Screen:
    - File upload should be Vertical on Mobile Screens
  • Issue-4: Form Stepper
    - Timeline Missing
    - Steps should be horizontal on Laptop/Desktop Screens
  • Issue-5: Tabs: appearance has Changed
  • Issue-6: Icon: Web page UI has changed
  • Issue-7: Inputs: width should be 30ch by default
  • Issue-8: App Footer: Padding Missing and content not aligned
  • Issue-9: Microsite header: padding Issue

Issue-1
Current:
image

Expected:
image

Issue-3:
Current:
image

Expected:
image

Issue-4:
Current:
image

Expected:
image
image

Issue-6:
Current:
image

Expected:
image

Issue-7:
Current:
image

Expected:
image

Issue-8:
Current:
image

Expected:
image

Issue-9:
Current:
image

Expected:
image

@ArakTaiRoth ArakTaiRoth linked an issue Sep 25, 2023 that may be closed by this pull request
Add postcss plugin to allow variables to be used within media-queries #1186
Closed
@Radha-Alberta Radha-Alberta marked this pull request as ready for review September 29, 2023 19:22
@ArakTaiRoth ArakTaiRoth merged commit 82a52c6 into GovAlta:alpha Oct 5, 2023
1 check passed
@tzuge
Copy link
Collaborator

tzuge commented Oct 11, 2023

🎉 This PR is included in version 1.15.0-alpha.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released on @alpha Released into alpha. label Oct 11, 2023
@tzuge
Copy link
Collaborator

tzuge commented Oct 11, 2023

🎉 This PR is included in version 4.15.0-alpha.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ArakTaiRoth ArakTaiRoth mentioned this pull request Oct 16, 2023
Closed
@tzuge
Copy link
Collaborator

tzuge commented Nov 1, 2023

🎉 This PR is included in version 4.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released Released into production. label Nov 1, 2023
@tzuge
Copy link
Collaborator

tzuge commented Nov 1, 2023

🎉 This PR is included in version 1.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Feb 21, 2024

🎉 This PR is included in version 2.6.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Feb 22, 2024

🎉 This PR is included in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanessatran-ddi vanessatran-ddi vanessatran-ddi approved these changes

@ArakTaiRoth ArakTaiRoth ArakTaiRoth approved these changes

@Radha-Alberta Radha-Alberta Awaiting requested review from Radha-Alberta

@amar-ABgov amar-ABgov Awaiting requested review from amar-ABgov

Assignees
No one assigned
Labels
released on @alpha Released into alpha. released Released into production.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add postcss plugin to allow variables to be used within media-queries
5 participants
@chrisolsen @Radha-Alberta @tzuge @ArakTaiRoth @vanessatran-ddi