Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#1264): add goa-calendar and goa-datepicker components #1339

Merged
merged 4 commits into from
Sep 21, 2023
Merged

feat(#1264): add goa-calendar and goa-datepicker components #1339

merged 4 commits into from
Sep 21, 2023

Conversation

chrisolsen
Copy link
Collaborator

No description provided.

@ArakTaiRoth ArakTaiRoth linked an issue Aug 28, 2023 that may be closed by this pull request
Date picker #1264
Closed
@Radha-Alberta
Copy link
Contributor

Radha-Alberta commented Aug 30, 2023 •
edited by chrisolsen
Loading

  • Issue-1: add examples in React App and Angular App
  • Issue-2: Date focus is not working
  • Issue-3: selecting unavailable date, month should change ? if yes, then selected date should move to available date
  • Issue-4: month dropdown scroll not working
  • Issue-5: opening dropdown, selected month should appear in dropdown list
  • Issue-6: Home Key, End Key, PageUp, PageDown, Shift+pageUp, Shift+PageDown Key are not working as expected
  • Issue-7: Mobile [ IOS-safari ]: improper selected date padding
  • Issue-8: IOS-Safari : blue border absent on Today's date
  • Issue-9: see the steps to reproduce: [ https://www.loom.com/share/d5c81806cc13422fbb25b8d5de608653?sid=b614ee5a-7265-4610-a830-ae2894703383 ]

Steps to Reproduce [ Issue-9 ]:

  1. Open Date picker with date attribute set as today's date.
  2. Move selected date with arrow keys
  3. move selected date to right (towards 31st August)
  4. move that to 1st September [ NOTE: user won't be able to see selected date ]
  5. click on any date from September [NOTE: month will change to October]

Issue-2:
image

Issue-7:
image

Issue-8:
image

@chrisolsen chrisolsen force-pushed the 1264-date-picker branch 2 times, most recently from 71f90dc to 0291295 Compare August 30, 2023 20:39
@Radha-Alberta
Copy link
Contributor

Radha-Alberta commented Aug 31, 2023 •
edited
Loading

  • Move to July by selecting unavailable date from August month. [No unavailable dates after 30 July]

Steps to Reproduce:

  1. open Today's Date
  2. Click on 31st July [This will be unavailable date]
  3. 31st July date will be selected. [ Issue: No Unavailable dates after 30 July. ]
  • Above issue also exist for 31st December 2023 and March 2024 and June 2024

https://www.loom.com/share/864a60c0409d4492b046b4a3d1d9333a?sid=4252943b-739e-46ae-9b65-5c5d8a9ef7d0

@chrisolsen chrisolsen force-pushed the 1264-date-picker branch 2 times, most recently from ffb6b19 to bd9111e Compare August 31, 2023 20:38
@Radha-Alberta
Copy link
Contributor

Radha-Alberta commented Sep 1, 2023 •
edited by chrisolsen
Loading

  • Issue-1: PageUp not working properly

  • Steps to Reproduce:

  1. Go to September 4th, 2023
  2. Press PageUp

Current Output: 5th August 2023
Expected Output: 4th August 2023
Similar Dates with Issue: 5th July 2023

  • Issue-2: Shift + page Up Not working as expected

  • Steps to Reproduce:

  1. Go to September 2nd, 2021
  2. Press Shift + PageUp

Current Output: 1st September 2020
Expected Output: 2nd September 2020
Similar Dates with Issue: 3rd September 2020

  • Issue-3: Angular: [ https://www.loom.com/share/6569fcacdca04382b6d0ee4fc2615fcb?sid=228bfd0d-c201-4427-9b83-da7731c526f8 ]
  1. Open Date picker
  2. press Tab to shift focus to month dropdown
  3. press shift+Tab to shift focus to previous element [ focus will move to last day of month, it should move to selected date]

Issue-4: Selecting date from date picker, input focus state should be active [just like date and time]( @tom can you confirm this is a bug or not ?)

@chrisolsen chrisolsen force-pushed the 1264-date-picker branch 2 times, most recently from 79544f0 to 8d26f3c Compare September 5, 2023 15:57
@Radha-Alberta
Copy link
Contributor

Radha-Alberta commented Sep 5, 2023 •
edited
Loading

  • Issue-1: space key : opens the date picker but scrolls the DOM page as well
  • Issue-2: In Min/Max : year dropdown has only current year
  • Issue-3: month/year dropdown should close, if we close the date picker
  • Issue-4: dropdown should open/close by pressing enter
  • Issue-5: Shift+PageDown goes till 2027, it should go till 2028 (up to 5 years forward)
  • Issue-6: there should be white underline border on the today's date,selected
  • Issue-7: extra double quotation below min/max date picker input

Issue-6
image
image

Issue-7:
image

@chrisolsen chrisolsen force-pushed the 1264-date-picker branch 2 times, most recently from b8fc8df to a956770 Compare September 7, 2023 17:46
@Radha-Alberta
Copy link
Contributor

Radha-Alberta commented Sep 8, 2023 •
edited
Loading

  • Issue-1: Accessibility: selecting the date, it should announce date including month and year
  • Issue-2: Accessibility: unable to select date with arrow keys, exists only when NVDA is active
  • Issue-3: not able to update date when NVDA is active.
  • Issue-4: once date is updated with keyboard, month and year value gets cleared

https://www.loom.com/share/2aa2da6a7e3442c7863116ba7f1c0448?sid=8d49d5c4-9c61-445f-9963-24d6bec8bd76

Steps to Reproduce: [ NOTE: use only keyboard ]

  1. Open date picker.
  2. select any date from date picker.
  3. reopen the date picker again [ Issue-4: month & year dropdown is cleared ]

@chrisolsen chrisolsen force-pushed the 1264-date-picker branch 2 times, most recently from 2709505 to 66fe6c0 Compare September 11, 2023 16:02
@Radha-Alberta Radha-Alberta marked this pull request as ready for review September 11, 2023 16:41
@chrisolsen
chore: formatting
2019077
@chrisolsen
fix: remove unwanted padding on top of goa-form-item
ec733dc
@chrisolsen
chore: remove the Enter key handling from Popover
03480ea 
This was preventing the expected behaviour when a dropdown (popover) exists within a popover
@GovAlta GovAlta deleted a comment from minhthytran Sep 13, 2023
@ArakTaiRoth ArakTaiRoth merged commit 7b23404 into GovAlta:alpha Sep 21, 2023
1 check passed
@tzuge
Copy link
Collaborator

tzuge commented Sep 21, 2023

🎉 This PR is included in version 4.15.0-alpha.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released on @alpha Released into alpha. label Sep 21, 2023
@tzuge
Copy link
Collaborator

tzuge commented Sep 21, 2023

🎉 This PR is included in version 1.15.0-alpha.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Nov 1, 2023

🎉 This PR is included in version 4.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released Released into production. label Nov 1, 2023
@tzuge
Copy link
Collaborator

tzuge commented Nov 1, 2023

🎉 This PR is included in version 1.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Feb 21, 2024

🎉 This PR is included in version 2.6.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Feb 22, 2024

🎉 This PR is included in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanessatran-ddi vanessatran-ddi vanessatran-ddi approved these changes

@ArakTaiRoth ArakTaiRoth ArakTaiRoth approved these changes

@Radha-Alberta Radha-Alberta Awaiting requested review from Radha-Alberta

@amar-ABgov amar-ABgov Awaiting requested review from amar-ABgov

Assignees
No one assigned
Labels
released on @alpha Released into alpha. released Released into production.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Date picker
5 participants
@chrisolsen @Radha-Alberta @tzuge @ArakTaiRoth @vanessatran-ddi