Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drawer component #1978

Closed
Spark450 opened this issue Jul 2, 2024 · 0 comments · Fixed by #2180
Closed

Drawer component #1978

Spark450 opened this issue Jul 2, 2024 · 0 comments · Fixed by #2180
Assignees
@chrisolsen
Labels
New Component A new component being worked on.

Comments

@Spark450
Copy link
Collaborator

Spark450 commented Jul 2, 2024 •
edited
Loading

Acceptance Criteria:

  • There are 2 drawer "types"

    • "Modal"
    • "Push"

  • Push drawer will need to be able to switch to modal drawer (user configurable value)

  • Scroll behaviour copies pattern set by our goa modal

Modal drawer

  • See Figma documentation for detailed design
  • On activation, adds a dark background
  • Must be dismissed to interact with the main page content (similar to how a modal works)

Push drawer

  • See Figma documentation for detailed design
  • Remains visible while users interact with primary content.
  • Users can interact with the main content or drawer content.

Accessibility

Animation

  • Talk to Rianna regarding animation of drawer component (drawer animating in and out, content animating in and out)

Release

  • Once issue has passed code review, inform @twjeffery so that he can prepare the Figma assets for release
@Spark450 Spark450 added the New Component A new component being worked on. label Jul 2, 2024
@twjeffery twjeffery mentioned this issue Jul 17, 2024
Closed
@ArakTaiRoth ArakTaiRoth moved this to 🔖 Ready in Design System Backlog Jul 17, 2024
chrisolsen added a commit to chrisolsen/ui-components that referenced this issue Oct 11, 2024
@chrisolsen
feat(GovAlta#1978): drawer component
b5dc124
@ArakTaiRoth ArakTaiRoth linked a pull request Oct 11, 2024 that will close this issue
feat: drawer component #2180
Merged
3 tasks
chrisolsen added a commit to chrisolsen/ui-components that referenced this issue Oct 15, 2024
@chrisolsen
fix(GovAlta#1978): drawer component
0d36ab1
chrisolsen added a commit to chrisolsen/ui-components that referenced this issue Oct 16, 2024
@chrisolsen
fix(GovAlta#1978): drawer component
8027bab
chrisolsen added a commit that referenced this issue Oct 22, 2024
@chrisolsen
feat(#1978): drawer component
62b3ea9
chrisolsen added a commit to chrisolsen/ui-components that referenced this issue Oct 22, 2024
@chrisolsen
feat(GovAlta#1978): drawer component
76e5499
chrisolsen added a commit to chrisolsen/ui-components that referenced this issue Oct 22, 2024
@chrisolsen
feat(GovAlta#1978): drawer component
d913271
chrisolsen added a commit to chrisolsen/ui-components that referenced this issue Oct 22, 2024
@chrisolsen
feat(GovAlta#1978): drawer component
56a3951
ArakTaiRoth pushed a commit that referenced this issue Oct 22, 2024
@chrisolsen @ArakTaiRoth
feat(#1978): drawer component
4d9d967
@github-project-automation github-project-automation bot moved this from 👀 In review to Alpha in Design System Backlog Oct 22, 2024
@ArakTaiRoth ArakTaiRoth mentioned this issue Oct 30, 2024
Merged
@Spark450 Spark450 mentioned this issue Nov 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisolsen chrisolsen

Labels
New Component A new component being worked on.
Projects
Design System Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: drawer component chrisolsen/ui-components
2 participants
@chrisolsen @Spark450