Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Disabled Input no longer appears disabled #1453

Closed
Tracked by #2094
ArakTaiRoth opened this issue Nov 8, 2023 · 6 comments · Fixed by #1467
Closed
Tracked by #2094

Bug: Disabled Input no longer appears disabled #1453

ArakTaiRoth opened this issue Nov 8, 2023 · 6 comments · Fixed by #1467
Assignees
@chrisolsen
Labels
Bug Something isn't working released on @alpha Released into alpha. released Released into production.

Comments

@ArakTaiRoth
Copy link
Collaborator

image

This can be replicated in our Angular Template and our React template as well, but is easiest seen in our Storybook.

Acceptance Criteria:

  1. Disabled input should not have a transparent background colour
@ArakTaiRoth ArakTaiRoth added the Bug Something isn't working label Nov 8, 2023
@ArakTaiRoth ArakTaiRoth moved this to 🔖 Ready in Design System Backlog Nov 9, 2023
@chrisolsen chrisolsen moved this from 🔖 Ready to 🏗 In progress in Design System Backlog Nov 15, 2023
@chrisolsen chrisolsen self-assigned this Nov 15, 2023
chrisolsen added a commit to chrisolsen/ui-components that referenced this issue Nov 15, 2023
@chrisolsen
fix(GovAlta#1453): fix input element's mis-named disabled styling
ff1746f
@chrisolsen chrisolsen moved this from 🏗 In progress to Testing in Design System Backlog Nov 15, 2023
@ArakTaiRoth ArakTaiRoth linked a pull request Nov 22, 2023 that will close this issue
fix(#1453): fix input element's mis-named disabled styling #1467
Merged
@ArakTaiRoth ArakTaiRoth moved this from Testing to 👀 In review in Design System Backlog Nov 23, 2023
chrisolsen added a commit to chrisolsen/ui-components that referenced this issue Nov 23, 2023
@chrisolsen
fix(GovAlta#1453): fix input element's mis-named disabled styling
d92fb22
chrisolsen added a commit to chrisolsen/ui-components that referenced this issue Nov 24, 2023
@chrisolsen
fix(GovAlta#1453): fix input element's mis-named disabled styling
80ba5c1
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Design System Backlog Nov 24, 2023
ArakTaiRoth pushed a commit that referenced this issue Nov 24, 2023
@chrisolsen @ArakTaiRoth
fix(#1453): fix input element's mis-named disabled styling
261217b
@tzuge
Copy link
Collaborator

tzuge commented Nov 24, 2023

🎉 This issue has been resolved in version 1.17.0-alpha.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released on @alpha Released into alpha. label Nov 24, 2023
@tzuge
Copy link
Collaborator

tzuge commented Nov 24, 2023

🎉 This issue has been resolved in version 4.17.0-alpha.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Nov 27, 2023

🎉 This issue has been resolved in version 4.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released Released into production. label Nov 27, 2023
@tzuge
Copy link
Collaborator

tzuge commented Nov 27, 2023

🎉 This issue has been resolved in version 1.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Feb 21, 2024

🎉 This issue has been resolved in version 2.6.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Feb 22, 2024

🎉 This issue has been resolved in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lizhuomeng71 lizhuomeng71 mentioned this issue Aug 29, 2024
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisolsen chrisolsen

Labels
Bug Something isn't working released on @alpha Released into alpha. released Released into production.
Projects
Design System Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#1453): fix input element's mis-named disabled styling chrisolsen/ui-components
3 participants
@chrisolsen @ArakTaiRoth @tzuge