Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyPress Event for Input Component #1398

Closed
ArakTaiRoth opened this issue Oct 5, 2023 · 0 comments · Fixed by #1456
Closed

KeyPress Event for Input Component #1398

ArakTaiRoth opened this issue Oct 5, 2023 · 0 comments · Fixed by #1456
Assignees
@amar-ABgov
Labels
Enhancement New feature or request

Comments

@ArakTaiRoth
Copy link
Collaborator

ArakTaiRoth commented Oct 5, 2023 •
edited
Loading

Info

Right now, there is no way to do anything on key press in our Input component. This means people are not allowed to track the Enter key being pressed in a form and being able to submit the form (like a search input).

Acceptance Criteria:

  1. New event for Input component - KeyPress
  2. This event should pass along the value of the input that the event was started in
@ArakTaiRoth ArakTaiRoth added the Enhancement New feature or request label Oct 5, 2023
@ArakTaiRoth ArakTaiRoth moved this to 🔖 Ready in Design System Backlog Oct 12, 2023
@amar-ABgov amar-ABgov self-assigned this Nov 2, 2023
@amar-ABgov amar-ABgov moved this from 🔖 Ready to 🏗 In progress in Design System Backlog Nov 2, 2023
amar-ABgov added a commit to amar-ABgov/ui-components that referenced this issue Nov 9, 2023
@amar-ABgov
feat(GovAlta#1398): Add keyPress event for input
9a04ec2
@amar-ABgov amar-ABgov moved this from 🏗 In progress to Testing in Design System Backlog Nov 9, 2023
@ArakTaiRoth ArakTaiRoth linked a pull request Nov 9, 2023 that will close this issue
feat(#1398): Add keyPress event for input #1456
Merged
amar-ABgov added a commit to amar-ABgov/ui-components that referenced this issue Nov 16, 2023
@amar-ABgov
feat(GovAlta#1398): Add keyPress event for input
e510aaf
@ArakTaiRoth ArakTaiRoth moved this from Testing to 👀 In review in Design System Backlog Nov 23, 2023
amar-ABgov added a commit to amar-ABgov/ui-components that referenced this issue Nov 28, 2023
@amar-ABgov
feat(GovAlta#1398): Add keyPress event for input
38ed41c
amar-ABgov added a commit to amar-ABgov/ui-components that referenced this issue Nov 29, 2023
@amar-ABgov
feat(GovAlta#1398): Add keyPress event for input
8ad375a
amar-ABgov added a commit to amar-ABgov/ui-components that referenced this issue Dec 4, 2023
@amar-ABgov
feat(GovAlta#1398): Add keyPress event for input
d71ea6d
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Design System Backlog Dec 4, 2023
chrisolsen pushed a commit that referenced this issue Dec 4, 2023
@amar-ABgov @chrisolsen
feat(#1398): Add keyPress event for input
da8160a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amar-ABgov amar-ABgov

Labels
Enhancement New feature or request
Projects
Design System Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#1398): Add keyPress event for input amar-ABgov/ui-components
2 participants
@ArakTaiRoth @amar-ABgov