Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Problems with Input Time #1380

Closed
chrisolsen opened this issue Sep 22, 2023 · 6 comments · Fixed by #1382
Closed

Bug: Problems with Input Time #1380

chrisolsen opened this issue Sep 22, 2023 · 6 comments · Fixed by #1382
Assignees
@ArakTaiRoth
Labels
Bug Something isn't working Documentation Improvements or additions to documentation released on @alpha Released into alpha. released Released into production.

Comments

@chrisolsen
Copy link
Collaborator

chrisolsen commented Sep 22, 2023 •
edited by ArakTaiRoth
Loading

The storybook example for GoAInputTime, is using a value of type Date, but only a string type is valid.

https://ui-components.alberta.ca/?path=/docs/components-inputs--time#time

In addition, the default step value of 60 is not actually set.

https://ui-components.alberta.ca/?path=/docs/components-inputs--time-with-seconds

image

Acceptance Criteria:

  1. Storybook example is changed to use a string value instead of Date
  2. Default step value is changed to 60, so seconds should not be shown by default.
@ArakTaiRoth ArakTaiRoth changed the title Fix storybook InputType example Bug: Problems with Input Time Sep 22, 2023
@ArakTaiRoth ArakTaiRoth added Bug Something isn't working Documentation Improvements or additions to documentation labels Sep 22, 2023
@ArakTaiRoth ArakTaiRoth moved this to 🏗 In progress in Design System Backlog Sep 22, 2023
@ArakTaiRoth ArakTaiRoth self-assigned this Sep 22, 2023
@ArakTaiRoth ArakTaiRoth linked a pull request Sep 22, 2023 that will close this issue
fix(#1380): Modify step value on Input. Modify time documentation to … #1382
Merged
@ArakTaiRoth ArakTaiRoth moved this from 🏗 In progress to Testing in Design System Backlog Sep 22, 2023
@Radha-Alberta Radha-Alberta moved this from Testing to 👀 In review in Design System Backlog Sep 26, 2023
ArakTaiRoth added a commit that referenced this issue Oct 3, 2023
@ArakTaiRoth
fix(#1380): Modify input time documentation
29ff97b
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Design System Backlog Oct 3, 2023
@tzuge
Copy link
Collaborator

tzuge commented Oct 11, 2023

🎉 This issue has been resolved in version 1.15.0-alpha.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released on @alpha Released into alpha. label Oct 11, 2023
@tzuge
Copy link
Collaborator

tzuge commented Oct 11, 2023

🎉 This issue has been resolved in version 4.15.0-alpha.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

ArakTaiRoth added a commit that referenced this issue Oct 26, 2023
@ArakTaiRoth
fix(#1380): Modify input time documentation
2bc993e
@tzuge tzuge mentioned this issue Oct 26, 2023
Closed
chrisolsen pushed a commit that referenced this issue Nov 1, 2023
@ArakTaiRoth @chrisolsen
fix(#1380): Modify input time documentation
9d7a2b1
@tzuge
Copy link
Collaborator

tzuge commented Nov 1, 2023

🎉 This issue has been resolved in version 4.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released Released into production. label Nov 1, 2023
@tzuge
Copy link
Collaborator

tzuge commented Nov 1, 2023

🎉 This issue has been resolved in version 1.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Feb 21, 2024

🎉 This issue has been resolved in version 2.6.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Feb 22, 2024

🎉 This issue has been resolved in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lizhuomeng71 lizhuomeng71 mentioned this issue Aug 29, 2024
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArakTaiRoth ArakTaiRoth

Labels
Bug Something isn't working Documentation Improvements or additions to documentation released on @alpha Released into alpha. released Released into production.
Projects
Design System Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#1380): Modify step value on Input. Modify time documentation to …
3 participants
@chrisolsen @ArakTaiRoth @tzuge