Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown menu rendering #1360

Closed
chrisolsen opened this issue Sep 5, 2023 · 7 comments · Fixed by #1460
Closed

Dropdown menu rendering #1360

chrisolsen opened this issue Sep 5, 2023 · 7 comments · Fixed by #1460
Assignees
@ArakTaiRoth
Labels
Bug Something isn't working released on @alpha Released into alpha. released Released into production.

Comments

@chrisolsen
Copy link
Collaborator

chrisolsen commented Sep 5, 2023 •
edited by ArakTaiRoth
Loading

Info

Currently the dropdown in Pagination renders with a specific width, and is thus not autosized as it should be.

Acceptance Criteria:

  1. Dropdown in Pagination should be autosized, not given a specific width
    • Remove width from line 81 in Pagination.svelte
<goa-dropdown bind:this={pageDropdownEl} value="{pagenumber}" width="70px">
@ArakTaiRoth ArakTaiRoth added the Bug Something isn't working label Sep 5, 2023
@Spark450 Spark450 moved this to 📋 Backlog in Design System Backlog Sep 14, 2023
@Spark450 Spark450 moved this from 📋 Backlog to 🔖 Ready in Design System Backlog Sep 15, 2023
@chrisolsen
Copy link
Collaborator Author

chrisolsen commented Sep 21, 2023 •
edited
Loading

Also renders to narrow when small strings exist as labels

Image

@Spark450 Spark450 moved this from 🔖 Ready to 🏗 In progress in Design System Backlog Nov 10, 2023
@ArakTaiRoth ArakTaiRoth moved this from 🏗 In progress to Testing in Design System Backlog Nov 10, 2023
@ArakTaiRoth ArakTaiRoth linked a pull request Nov 14, 2023 that will close this issue
fix(#1360): Removed width from Pagination dropdown #1460
Merged
@ArakTaiRoth ArakTaiRoth moved this from Testing to 👀 In review in Design System Backlog Nov 17, 2023
ArakTaiRoth added a commit that referenced this issue Nov 20, 2023
@ArakTaiRoth
fix(#1360): Removed width from Pagination dropdown
fac599f
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Design System Backlog Nov 20, 2023
@tzuge
Copy link
Collaborator

tzuge commented Nov 20, 2023

🎉 This issue has been resolved in version 1.17.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released on @alpha Released into alpha. label Nov 20, 2023
@tzuge
Copy link
Collaborator

tzuge commented Nov 20, 2023

🎉 This issue has been resolved in version 4.17.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Nov 27, 2023

🎉 This issue has been resolved in version 4.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released Released into production. label Nov 27, 2023
@tzuge
Copy link
Collaborator

tzuge commented Nov 27, 2023

🎉 This issue has been resolved in version 1.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Feb 21, 2024

🎉 This issue has been resolved in version 2.6.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Feb 22, 2024

🎉 This issue has been resolved in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArakTaiRoth ArakTaiRoth

Labels
Bug Something isn't working released on @alpha Released into alpha. released Released into production.
Projects
Design System Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#1360): Removed width from Pagination dropdown
3 participants
@chrisolsen @ArakTaiRoth @tzuge