setup: Add __version__ attribute for the tasklib module #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Providing __version__ attribute is a reasonably common convention among packages in the Python ecosystem. Currently the only other reliable alternative is to use pkg_resources.get_distribution method, however, importing pkg_resources is notoriously slow [1,2]. Provide the __version__ attribute to provide an API interface to check the version of tasklib at runtime. Bump the version in order to reflect module API change. [1] pypa/setuptools#510 [2] pypa/setuptools#926
|
@robgolding This would also need a PyPi release 🙏 |
tbabej
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing
__version__attribute is a reasonably common convention amongpackages in the Python ecosystem. Currently the only other reliable
alternative is to use pkg_resources.get_distribution method, however,
importing pkg_resources is notoriously slow [1,2].
Provide the
__version__attribute to provide an API interface to checkthe version of tasklib at runtime.
Bump the version in order to reflect module API change.
[1] pypa/setuptools#510
[2] pypa/setuptools#926