Added _get_task_attrs method to backend #50

lyz-code · 2018-01-26T09:33:10Z

Hi, I'm adding the feature of being able to parse the history of taskwarrior
(through the undo.data).

One application of this feature that I'm also writing is the ability to measure
the total time spent on tasks, without the ugly hack of adding an annotation
each time you start or stop a task. That info is already in the undo.data.

So, instead of a huge MR I'm splitting it to be somewhat edible :)

I need this method to parse the available task attributes of the undo.data file.

I've also added a minimum support of UDAs detection of the config, it doesn't
solve issue #30 but it's
a start.

Cheers

…tead of the whole history.monthly

* Write test of _convert_timestamp

* Tests for parsing history entry * Remove udas from tests data

coveralls · 2018-01-26T11:07:55Z

Coverage increased (+0.1%) to 91.72% when pulling 10e2f03 on lyz-code:feature/get_task_attributes into 79e9a98 on robgolding:develop.

* Added tests for active_time method

jamatute · 2018-02-21T18:40:55Z

Hi @robgolding, is there anything I can do to help with the review of the Pull request?

robgolding · 2018-03-05T21:19:49Z

Sorry for the delay, I'll go over this now.

robgolding

Not really sure what the purpose of this PR is @lyz-code—perhaps if it had more context and the usage of the new method was shown it would be easier to review and suggest an implementation.

Thanks so much for the contribution to the project, look forward to seeing what you suggest!

robgolding · 2018-03-05T21:20:15Z

tasklib/backends.py

@@ -245,7 +245,7 @@ def filter_class(self):

    @property
    def config(self):
-        # First, check if memoized information is available
+        # First, check if memorized information is available


This isn't a typo 😄 it refers to memoization (I know, weird word!)

Ouups, sorry, I didn't know the word nor my corrector.

Restored on cf4d52a

robgolding · 2018-03-05T21:27:31Z

tasklib/backends.py

@@ -427,3 +427,34 @@ def valid(output):

    def sync(self):
        self.execute_command(['sync'])
+
+    def _get_task_attrs(self):
+        TASK_STANDARD_ATTRS = [


I think this would be good to define on the class itself (either the backend or Task) rather than in the method.

Moved on commit 7805380

robgolding · 2018-03-05T21:27:56Z

tasklib/backends.py

+            if 'uda' in index:
+                udas.add(re.sub(r'.*uda\.(.*?)\..*', r'\1', index))
+        available_task_attrs.extend(udas)
+        self.available_task_attrs = tuple(available_task_attrs)


Since the method is a "getter", it should return something rather than just set an attribute on the object.

You are right, I changed it to _set_task_attrs on 7805380

robgolding · 2018-03-05T21:28:19Z

tasklib/backends.py

+        available_task_attrs = TASK_STANDARD_ATTRS
+        udas = set()
+        for index in self.config:
+            if 'uda' in index:


Should this not check for index.startswith('uda.')?

Yup, fixed in f055fce @robgolding

* Change _get_task_attrs to _set_task_attrs

lyz-code · 2018-03-06T09:13:07Z

I didn't want to make a huge PR, instead I'll do several small ones to make it
bearable :).

That's why this may seem a little bit out of context.

I need this method because the undo.data file has lines with the following format:

time 1508839796
new [description:"Create ansible playbook to deploy backupninja" entry:"1482393062" est:"1.000000" modified:"1486571719" priority:"L" project:"sis" status:"pending" tags:"ansible" uuid:"22a0a917-923b-48a0-a20f
-f08e2eca119a"]
---

I need to know the available task attributes and udas to convert that format to
json to be able to load it into a dictionary. I saw this way of doing things better than accepting any word:" regexp

for key in self.backend.available_task_attrs:
	... process the data_line ...

history_entry = json.loads(data_line)

You can find the whole code
here
under the TaskHistory class, method _convert_history_entry

lyz-code · 2018-03-06T13:50:16Z

@robgolding Seems that the SCM of travis is broken again

…n the attributes

Fix/undo data parse error

robgolding · 2018-03-18T09:41:16Z

I'd prefer to see all the changes in context @lyz-code, so one big PR is probably preferable here actually.

Also I need to fix the Git repo location now taskwarrior has moved to GitHub!

…z-code/tasklib into feature/get_task_attributes

lyz-code · 2020-09-07T14:42:26Z

Closing for inactivity

lyz-code added 24 commits June 5, 2017 15:11

* [feat] Get total active time of a task

8c50ede

* [feat] Get history of just one task

d0a3632

* [fix] delete the get_history of one task_uuid, it makes no sense

24fdeb2

* [fix] better name for task method

678217a

* [feat] Modify active_time to measure time for active tasks

6608f45

* [feat] Modify active_time to accept a period of time to process ins…

9f5bc80

…tead of the whole history.monthly

* [feat] Implement a cache of tw.get_history so the command goes faster

adce391

* [WIP] Start testing the module

e055076

[fix] try catch for wrong formatted lines

423a0cb

[fix] add instatus key

0b63e53

[wip] start refactoring

ab74266

[wip][feat] get_available keys with tdd

bb90329

* Finish tests of get_available_keys

9a8d479

* Write test of _convert_timestamp

* Change TaskHistory from inheritance to composition

5e23591

* Tests for parsing history entry * Remove udas from tests data

[wip] Move the test_get_task_attrs_without_udas test

976ea13

Update branch with robgolding/tasklib

780803c

Merge branch 'robgolding-develop' into feat/history-filter-one-task

48b2b63

Added tests to _load_history_from_source()

7d73648

Added save_history tests

5a88a6d

Added _load_history_from_cache method

6e832f4

Update gitignore

2c3d89e

Added _cache_is_updated method

deb64a8

Added get_history method

16cab32

Added _get_task_attrs method to backend

10e2f03

* Added KeyError exception catch for get_history method

cbcee78

* Added tests for active_time method

lyz-code added 3 commits February 23, 2018 09:27

* Change behavior of active time, instead of now - {}, accept a string

86e4d85

* Add error message when json fails

ef457a7

* Expand history cache as user

63efbf8

lyz-code added 3 commits March 2, 2018 13:04

* Make sure that the test of cache loading can't load from source

613b088

* Fixed the relative path loading of history cache

34ea9c1

* Fix variable expansion on history cache path

a1a2d7c

robgolding requested changes Mar 5, 2018

View reviewed changes

lyz-code added 3 commits March 6, 2018 09:02

Restored memoized

cf4d52a

* Move TASK_STANDARD_ATTRS to the Backend class

7805380

* Change _get_task_attrs to _set_task_attrs

* Improve uda checking conditional

f055fce

lyz-code added 3 commits March 16, 2018 09:30

* Fixed the parsing of undo.data line with more than one space betwee…

1094a6f

…n the attributes

* Fix typo

b24660f

Merge pull request #4 from lyz-code/fix/undo-data-parse-error

4eb95f2

Fix/undo data parse error

lyz-code added 2 commits March 19, 2018 16:00

Merge branch 'feat/history-filter-one-task' of github-personal.com:ly…

ee47943

…z-code/tasklib into feature/get_task_attributes

Fixed PEP8 format

9ac18a6

lyz-code mentioned this pull request Mar 19, 2018

Add support to measure active time of tasks #55

Closed

lyz-code closed this Sep 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added _get_task_attrs method to backend #50

Added _get_task_attrs method to backend #50

lyz-code commented Jan 26, 2018

coveralls commented Jan 26, 2018 •

edited

Loading

jamatute commented Feb 21, 2018

robgolding commented Mar 5, 2018

robgolding left a comment

robgolding Mar 5, 2018

lyz-code Mar 6, 2018

robgolding Mar 5, 2018

lyz-code Mar 6, 2018

robgolding Mar 5, 2018

lyz-code Mar 6, 2018

robgolding Mar 5, 2018

lyz-code Mar 6, 2018

lyz-code commented Mar 6, 2018

lyz-code commented Mar 6, 2018

robgolding commented Mar 18, 2018

lyz-code commented Sep 7, 2020

Added _get_task_attrs method to backend #50

Added _get_task_attrs method to backend #50

Conversation

lyz-code commented Jan 26, 2018

coveralls commented Jan 26, 2018 • edited Loading

jamatute commented Feb 21, 2018

robgolding commented Mar 5, 2018

robgolding left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lyz-code commented Mar 6, 2018

lyz-code commented Mar 6, 2018

robgolding commented Mar 18, 2018

lyz-code commented Sep 7, 2020

coveralls commented Jan 26, 2018 •

edited

Loading