Make cache directory path Windows friendly #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing logic for building the cache directory path assumes *nix style paths when attempting to make a unique cache dir for each test fixture and step. Paths with a Windows drive prefix on the front ("C:\...") muck this up. Pathlib's '/' operator silently covers this up (under Python 3.9 on Windows, at least).
This change preserves the uniqueness logic whilst being Window friendly by taking a hash of the path to the test fixture's configuration directory `tfdir` and using that in the cache directory path construction.
|
I don't see how the change I introduces caused the Linting status check to fail. |
|
Thanks for this! Can you check the linting errors? Linter configuration is in the ci workflow files in the |
Might be my fault even though I don't think I pushed to master outside a PR recently. Simplest solution is to fix it, I can do that if you prefer. :) |
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing logic for building the cache directory path assumes *nix style paths when attempting to make a unique cache dir for each test fixture and step. Paths with a Windows drive prefix on the front ("C:\...") muck this up. Pathlib's '/' operator silently covers this up (under Python 3.9 on Windows, at least).
This change reasonably preserves the uniqueness logic whilst being Window friendly by taking a hash of the path to the test fixture's configuration directory
tfdirand using that in the cache directory path construction.