Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] added support to pass a complex dict #69

Merged
merged 4 commits into from
Jan 26, 2023
Merged

[feature] added support to pass a complex dict #69

merged 4 commits into from
Jan 26, 2023

Conversation

MrImpossibru
Copy link
Contributor

#68

added support to pass a complex dict to the tf_vars parameter

Like that:
tf_vars = { "pep_spec": { "pep1": "test", "list": [ "item1", "item2" ] }, "list2": [ "item1", "item2" ] }

@google-cla
Copy link

google-cla bot commented Jan 26, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ludoo
Copy link
Collaborator

ludoo commented Jan 26, 2023

Can you add a test? If you're too busy let me know and I can add it, provided I can work on the fork.

@MrImpossibru
Copy link
Contributor Author

@ludoo I can try, I'm not a python dev TBH :)

@MrImpossibru
Copy link
Contributor Author

@ludoo I commited some tests

@MrImpossibru
Copy link
Contributor Author

@ludoo Should I do something with the Linting?

@ludoo
Copy link
Collaborator

ludoo commented Jan 26, 2023

@ludoo Should I do something with the Linting?

if you have time, linting we use is autopep8 with 2 spaces for tab stop, I can do it quickly as soon as I have 5 free minutes, let me try

@ludoo
Copy link
Collaborator

ludoo commented Jan 26, 2023

Merging this, thanks a lot for your patience. I am going to release it on pypi ASAP

@ludoo ludoo merged commit 707a604 into GoogleCloudPlatform:master Jan 26, 2023
@MrImpossibru
Copy link
Contributor Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants