Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double close on Windows 10 #51

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

sueastside
Copy link
Contributor

Fix double close on Windows 10.0.19044 N/A Build 19044.

Exception in thread Thread-1:
Traceback (most recent call last):
File "C:\Users\user\AppData\Local\Programs\Python\Python37\lib\threading.py", line 926, in _bootstrap_inner
self.run()
File "C:\Users\G000737\AppData\Local\Programs\Python\Python37\lib\threading.py", line 870, in run
self._target(*self._args, **self._kwargs)
File "C:\Users\user\AppData\Local\Programs\Python\Python37\lib\subprocess.py", line 1267, in _readerthread
buffer.append(fh.read())
ValueError: I/O operation on closed file.

Exception in thread Thread-1:
Traceback (most recent call last):
  File "C:\Users\user\AppData\Local\Programs\Python\Python37\lib\threading.py", line 926, in _bootstrap_inner
    self.run()
  File "C:\Users\G000737\AppData\Local\Programs\Python\Python37\lib\threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)
  File "C:\Users\user\AppData\Local\Programs\Python\Python37\lib\subprocess.py", line 1267, in _readerthread
    buffer.append(fh.read())
ValueError: I/O operation on closed file.
@google-cla
Copy link

google-cla bot commented Aug 4, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ludoo
Copy link
Collaborator

ludoo commented Aug 4, 2022

And thanks for this!

@ludoo ludoo closed this Aug 4, 2022
@ludoo ludoo reopened this Aug 4, 2022
@ludoo ludoo merged commit 23766e2 into GoogleCloudPlatform:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants