Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail when resource_changes key not present in output #27

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Don't fail when resource_changes key not present in output #27

merged 2 commits into from
Apr 15, 2021

Conversation

brownmike
Copy link
Contributor

Fix for #26 tftest failed when terraform plan is empty

@google-cla
Copy link

google-cla bot commented Apr 14, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@brownmike
Copy link
Contributor Author

@googlebot I signed it!

@ludoo
Copy link
Collaborator

ludoo commented Apr 15, 2021

Thanks for this!

@ludoo ludoo merged commit 78981fe into GoogleCloudPlatform:master Apr 15, 2021
@brownmike brownmike deleted the bugfix/plan-without-resources branch April 19, 2021 16:19
ludoo added a commit that referenced this pull request Jun 5, 2021
* Don't fail when resource_changes key not present in output (#27)

* Resolves #26 tftest failed when terraform plan is empty

* add missing copyright boilerplate

Co-authored-by: Ludovico Magnocavallo <[email protected]>

* Update CHANGELOG.md

* Update CHANGELOG.md

* v1.5.6 for pypi

* made minimal changes to fix tests (now all passed locally for me)

* added a bit of code to parse run-all output and test to assert output

* added terragrunt run in single dir test case + simplified run-all

* added test cases for terragrunt parse args

* refactored terragrunt cmd line parameters parsing

* refactored as a separated class(TerragruntTest) but reused most of TerraformTest

Co-authored-by: Mike Brown II <[email protected]>
Co-authored-by: Ludovico Magnocavallo <[email protected]>
Co-authored-by: Ludovico Magnocavallo <[email protected]>
ludoo added a commit that referenced this pull request Jun 7, 2021
* Add Terragrunt integration and general parser (#24)

* - add kw parser
- add tg command methods

* - add plan_all parse output progress
- replace terra* command func cli params with **kw

* add tgbinary to ci

* - add tg shared doc string decorator
- separate some of the public methods tg_xxx() | tf_xxx()
- fix parse_args() styling

* - Rollback parse_args()
- Add tg global args to parse_args()
- Add tg global args decorator
- Add all param to tg_xxx methods

* - mv tg flags before tf flags for cli args
- add common tg args to tg methods

* - fix tg source module warning
- add output() fixture to tg test

* bump version

* Terragrunt support (#29)

* Don't fail when resource_changes key not present in output (#27)

* Resolves #26 tftest failed when terraform plan is empty

* add missing copyright boilerplate

Co-authored-by: Ludovico Magnocavallo <[email protected]>

* Update CHANGELOG.md

* Update CHANGELOG.md

* v1.5.6 for pypi

* made minimal changes to fix tests (now all passed locally for me)

* added a bit of code to parse run-all output and test to assert output

* added terragrunt run in single dir test case + simplified run-all

* added test cases for terragrunt parse args

* refactored terragrunt cmd line parameters parsing

* refactored as a separated class(TerragruntTest) but reused most of TerraformTest

Co-authored-by: Mike Brown II <[email protected]>
Co-authored-by: Ludovico Magnocavallo <[email protected]>
Co-authored-by: Ludovico Magnocavallo <[email protected]>

* speed up tests(session scope to reuse fixtures) + work around for strange tf run-all plan behaviour

* added back change log

* adding newline at end of file

* Adding terragrunt section to readme

* added some doc strings

* remove binary param from _clean_up to fix tests

* Update README.md

* Update README.md

* Update CHANGELOG.md

* Update tftest.py

Co-authored-by: Marshall Mamiya <[email protected]>
Co-authored-by: Ludovico Magnocavallo <[email protected]>
Co-authored-by: Mike Brown II <[email protected]>
Co-authored-by: Ludovico Magnocavallo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants