Remove unused startup scripts #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgewilli
added a commit
that referenced
this pull request
Oct 10, 2017
* Fixing POM file to get rid of maven warnings * Changed formatting checks to check for the Google formatting rules and adapted code to these rules. See https://google.github.io/styleguide/javaguide.html * Changed to older version of checkstyle to be compatible with JDK 1.7 * Revert "Changed to older version of checkstyle to be compatible with JDK 1.7" This reverts commit 7376b6a. * Check Google code style only at the end and only using JDK1.8 * For the actual tests, stop at the integration-test phase rather than also verify. Run verify once, separately and using JDK8 only. * Reverting some changes in jms-light/pom.xml that might have somehow influenced the global behavior of maven * Added a timeout while waiting for the fake server to terminate * Fixing POM file to get rid of maven warnings * Changed formatting checks to check for the Google formatting rules and adapted code to these rules. See https://google.github.io/styleguide/javaguide.html * Changed to older version of checkstyle to be compatible with JDK 1.7 * Revert "Changed to older version of checkstyle to be compatible with JDK 1.7" This reverts commit 7376b6a. * Check Google code style only at the end and only using JDK1.8 * For the actual tests, stop at the integration-test phase rather than also verify. Run verify once, separately and using JDK8 only. * Reverting some changes in jms-light/pom.xml that might have somehow influenced the global behavior of maven * Added a timeout while waiting for the fake server to terminate * Put tests back, but disable them * add go subscriber loadtest (#74) * typo * add go subscriber * automatically compile go loadtest binary * pr comment * Add PubSubTemporaryTopic class * Improves error messages, enables Go message tracking. * Update README.md * Update README.md * Update README.md * Fix null key and exception about read-only ByteBuffer that happens wh… (#78) * Fix null key and exception about read-only ByteBuffer that happens when using a JsonConverter in a source connector. * Fix null key and exception about read-only ByteBuffer that happens when using a JsonConverter in a source connector. * added source file * nit * nit * nit * use public access * use extends * Moved mockito and junit to the test scope. Removed the dependency on the kafka client. This is provided by the connect-api. Changed the scope of connect-api to provided. Updated the kafka version to 0.10.2.0. (#84) * nit * Initial version of PubSubMessageConsumer. * added file * added constructor * nit * fix pmd * nit * nit * added file * added -Xlint:all to all compile * Xlint Configuration This is the configuration that I used. With this, I get the following warnings (the second one is probably independent of -Xlint): ... [WARNING] /usr/local/google/home/uhu/src/pubsub/jms-light/src/main/java/com/google/pubsub/jms/light/message/PubSubTextMessage.java:[39,16] unchecked cast required: T found: java.lang.String ... [WARN] /usr/local/google/home/uhu/src/pubsub/jms-light/src/main/java/com/google/pubsub/jms/light/PubSubTopicSession.java:9: Wrong lexicographical order for 'com.google.pubsub.jms.light.destination.PubSubTemporaryTopic' import. Should be before 'javax.jms.TemporaryTopic'. [CustomImportOrder] [WARN] /usr/local/google/home/uhu/src/pubsub/jms-light/src/main/java/com/google/pubsub/jms/light/PubSubTopicConnectionFactory.java:12: Line is longer than 100 characters (found 109). [LineLength] [WARN] /usr/local/google/home/uhu/src/pubsub/jms-light/src/main/java/com/google/pubsub/jms/light/PubSubTopicConnectionFactory.java:20: Line is longer than 100 characters (found 114). [LineLength] * Resolved unchecked cast * Cleaned code style, especially for test classes. This addresses Github JMS issue #92. * nit * nit * Handle a null schema in the sink connector. (#94) * Adding ${os.detected.classifier} to Pom (#96) Just adding ${os.detected.classifier} to Pom so the right netty-tcnative-boring-ssl-static library is selected. This is to ensure the connector can work in any OS (e.g. OSX). * Fix concurrent access on iteration of synchronized set. (#98) * Handle a null schema in the sink connector. * Fix concurrent access on iteration of synchronized set. * Reduce the ackIds iteration synchronization to the shortest period needed * Make acks best effort. (#99) * Clear list of ackIds as soon as acks are sent. This will make acks best effort, but also prevents us from forgetting to send some acks if a poll happens while there is an outstanding ack request * Better error message when verifySubscription fails. (#100) * Better error message when verifySubscription fails. * When an exception happens on pull, just return an empty list to poll. (#102) * Handle a null schema in the sink connector. * Fix concurrent access on iteration of synchronized set. * Reduce the ackIds iteration synchronization to the shortest period needed * Clear list of ackIds as soon as acks are sent. This will make acks best effort, but also prevents us from forgetting to send some acks if a poll happens while there is an outstanding ack request * Better error message when verifySubscription fails. * When an exception happens on pull, just return an empty list to poll. * don't depend on gRPC internals (#103) * Don't reference gRPC internal classes * don't depend on gRPC internals * Create README.md * Ensure that partition numbers are non-negative (#105) * Ensure partition number is non-negative in CPS source connector. * Update client library dependencies. * Update Framework with Java Beta Client (#108) * Update Framework with Java Beta Client Updates the framework with the Java Beta client, and removes the experimental client now that the changes have been merged into the google-cloud-java repository. * Remove previous "spi" from import paths * Minor bugfixes, removed VTK since it no longer exists * Remove unused startup scripts (#110) * Remove Alpha Client Libraries, Redirect to google-cloud-java (#109) * Remove Alpha Client Libraries, Redirect to google-cloud-java * Removed client from .travis.yml * readme fix * lint fixes * Added Ruby publisher * updated publisher * Added Ruby subscriber * fixed comments * fixes for CPS Subscriber, updates with new Python publisher * python subscriber * fix firewall * Update run.py Fix for python3 * Shade the guava library to avoid a NoMethodFoundError (#117) * Handle a null schema in the sink connector. * Fix concurrent access on iteration of synchronized set. * Reduce the ackIds iteration synchronization to the shortest period needed * Clear list of ackIds as soon as acks are sent. This will make acks best effort, but also prevents us from forgetting to send some acks if a poll happens while there is an outstanding ack request * Better error message when verifySubscription fails. * When an exception happens on pull, just return an empty list to poll. * Ensure partition number is non-negative in CPS source connector. * Shade out the guava library so the connector can work with a newer version of Kafka that depends on a newer version of the guava library. * Shade out the guava library so the connector can work with a newer version of Kafka that depends on a newer version of the guava library. * fix * Fix some broken markdown in the README (#119) Some newlines snuck their way into these links * Update run.py Uncomment Go * java: don't sync on shutdown (#125) * java: don't sync on shutdown Shutting down needs to wait for messages to be processed, and processing the messages need to lock the Task object. So, if the thread calling shutdown locks the Task object, we'll deadlock. * pr comment * increase parallel puller count (#124) * increase parallel puller count The new default number of parallel pullers is NumCPU. To keep up with publishers, we need to increase the number of pullers. This commit increaes the number to 5*NumCPU, the same as the old default. * bump version * Move away from very old versions of gRPC libraries (#130) * Handle a null schema in the sink connector. * Fix concurrent access on iteration of synchronized set. * Reduce the ackIds iteration synchronization to the shortest period needed * Clear list of ackIds as soon as acks are sent. This will make acks best effort, but also prevents us from forgetting to send some acks if a poll happens while there is an outstanding ack request * Better error message when verifySubscription fails. * When an exception happens on pull, just return an empty list to poll. * Ensure partition number is non-negative in CPS source connector. * Shade out the guava library so the connector can work with a newer version of Kafka that depends on a newer version of the guava library. * Shade out the guava library so the connector can work with a newer version of Kafka that depends on a newer version of the guava library. * Update versions of gRPC libraries used by Kafka Connector. This should hopefully fix issue #120. * Edit travis script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.