Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add k8s.cluster.uid fallback for GMP #877

Merged

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Aug 5, 2024

fixes #771

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.75%. Comparing base (4caace7) to head (832a421).
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #877      +/-   ##
==========================================
+ Coverage   61.03%   61.75%   +0.71%     
==========================================
  Files          56       58       +2     
  Lines        5903     6055     +152     
==========================================
+ Hits         3603     3739     +136     
- Misses       2143     2156      +13     
- Partials      157      160       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dashpole dashpole marked this pull request as ready for review August 5, 2024 20:05
@dashpole dashpole requested a review from a team as a code owner August 5, 2024 20:05
@dashpole dashpole merged commit 9256e9e into GoogleCloudPlatform:main Aug 6, 2024
29 checks passed
@dashpole dashpole deleted the container_name_fallback branch August 6, 2024 13:41
@dashpole dashpole mentioned this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fall back to k8s.cluster.id when k8s.cluster.name is not available
2 participants