-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert to go 1.20 and prepare for v1.19.1/v0.43.1 #717
Conversation
cc @anuraaga |
Thanks for the quick fix! 🙏 |
Codecov Report
@@ Coverage Diff @@
## main #717 +/- ##
==========================================
+ Coverage 69.66% 69.75% +0.08%
==========================================
Files 38 38
Lines 4754 4754
==========================================
+ Hits 3312 3316 +4
+ Misses 1295 1291 -4
Partials 147 147
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hi @dashpole - I randomly realized that opentelemetry-go-contrib targets 1.19 and depends on this library https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/detectors/gcp/go.mod AFAIK, this isn't really allowed, basically if someone tries to compile that library with 1.19 it will fail due to the missing My project is now on 1.20 so not personally affected but wanted to share as it looks like it could be a problem for other users of the opentelemetry-go-contrib library. |
Ah, thanks. I think we are technically OK, as the Contrib is using the patch release already, so you shouldn't need a replace: https://github.com/open-telemetry/opentelemetry-go-contrib/blob/3ad5a2c545431824f851c62be1c9253a59427c07/detectors/gcp/go.mod#L7 |
See #708 (comment). We should set the go version in our go.mod to the minimum version we support, which is go 1.20.
Also, prepare for a patch release.