Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trace and logging user agent, and add tests #714

Merged
merged 9 commits into from
Aug 23, 2023

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Aug 23, 2023

Fixes #713.

I also discovered that the logging exporter was not overriding {{version}} in user agent.

This adds the user agent to the fixture tests, and adds a test to specifically check that the user_agent config is applied to outgoing requests.

@dashpole dashpole marked this pull request as ready for review August 23, 2023 17:01
@dashpole dashpole requested a review from a team as a code owner August 23, 2023 17:01
@dashpole dashpole requested a review from aabmass August 23, 2023 17:01
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #714 (7077b62) into main (858780d) will decrease coverage by 0.03%.
The diff coverage is 40.74%.

@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
- Coverage   69.60%   69.58%   -0.03%     
==========================================
  Files          37       38       +1     
  Lines        4728     4754      +26     
==========================================
+ Hits         3291     3308      +17     
- Misses       1289     1299      +10     
+ Partials      148      147       -1     
Files Changed Coverage Δ
...er/collector/integrationtest/protos/fixtures.pb.go 39.42% <0.00%> (-3.07%) ⬇️
exporter/collector/logs.go 45.35% <0.00%> (-0.13%) ⬇️
...er/collector/integrationtest/inmemoryocexporter.go 87.71% <100.00%> (+0.10%) ⬆️
...lector/integrationtest/testcases/testcases_logs.go 100.00% <100.00%> (ø)
...tor/integrationtest/testcases/testcases_metrics.go 100.00% <100.00%> (ø)
...ctor/integrationtest/testcases/testcases_traces.go 100.00% <100.00%> (ø)
exporter/trace/trace.go 90.16% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@dashpole dashpole merged commit 92fd371 into GoogleCloudPlatform:main Aug 23, 2023
@dashpole dashpole deleted the fix_trace_user_agent branch August 23, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Agent passed to SDK trace exporter is not respected.
2 participants