-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix trace and logging user agent, and add tests #714
Merged
dashpole
merged 9 commits into
GoogleCloudPlatform:main
from
dashpole:fix_trace_user_agent
Aug 23, 2023
Merged
Fix trace and logging user agent, and add tests #714
dashpole
merged 9 commits into
GoogleCloudPlatform:main
from
dashpole:fix_trace_user_agent
Aug 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #714 +/- ##
==========================================
- Coverage 69.60% 69.58% -0.03%
==========================================
Files 37 38 +1
Lines 4728 4754 +26
==========================================
+ Hits 3291 3308 +17
- Misses 1289 1299 +10
+ Partials 148 147 -1
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
aabmass
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #713.
I also discovered that the logging exporter was not overriding
{{version}}
in user agent.This adds the user agent to the fixture tests, and adds a test to specifically check that the user_agent config is applied to outgoing requests.