Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: remove SA attached to GCE #425

Merged
merged 10 commits into from
Oct 7, 2022
Merged

improvement: remove SA attached to GCE #425

merged 10 commits into from
Oct 7, 2022

Conversation

Shabirmean
Copy link
Member

@Shabirmean Shabirmean commented Sep 21, 2022

Fixes #424

Description

Change summary

  • Remove association of Service Account in the instance template that is created
  • Copy the Service Account used for running Terraform into the GCE VMs once they are created
  • Update the scripts to make use of this Service Account when running their commands
  • Fix broken tests

Related PRs/Issues

@Shabirmean Shabirmean requested a review from a team as a code owner September 21, 2022 03:14
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 21, 2022
minherz and others added 3 commits October 6, 2022 19:13
* fix: explicitly enable gkeconnect API

Fix test flakiness (like [1]) by explicitly enabling gkeconnect.googleapis.com
[1] https://github.com/GoogleCloudPlatform/anthos-samples/actions/runs/3190598002/jobs/5205918332

* chore: fix tf list syntax

* chore: fix tf formatting
* feature: add GCE VM bash scripts

* cleanup: update .gitignore

* cleanup: add FAQ section

* cleanup: add FAQ section

* cleanup: shellcheck lint

* cleanup: remove extra space

* cleanup: add script indent

* cleanup: fix ci comments

* cleanup: add explanatory note
@snippet-bot
Copy link

snippet-bot bot commented Oct 6, 2022

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@Shabirmean Shabirmean requested a review from minherz October 6, 2022 23:44
@Shabirmean Shabirmean enabled auto-merge (squash) October 7, 2022 13:38
@minherz minherz changed the title improvement: remove SA attahced to GCE improvement: remove SA attached to GCE Oct 7, 2022
Copy link
Contributor

@minherz minherz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a couple of nit remarks.

@Shabirmean Shabirmean merged commit fb4c32c into main Oct 7, 2022
@Shabirmean Shabirmean deleted the remove-gce-sa branch October 7, 2022 21:29
Shabirmean added a commit that referenced this pull request Oct 12, 2022
* improvement: remove SA attahced to GCE

* cleanup: explicitly enable gkeconnect API (#439)

* fix: explicitly enable gkeconnect API

Fix test flakiness (like [1]) by explicitly enabling gkeconnect.googleapis.com
[1] https://github.com/GoogleCloudPlatform/anthos-samples/actions/runs/3190598002/jobs/5205918332

* chore: fix tf list syntax

* chore: fix tf formatting

* feature: add ABM on GCE VM bash script sample (#437)

* feature: add GCE VM bash scripts

* cleanup: update .gitignore

* cleanup: add FAQ section

* cleanup: add FAQ section

* cleanup: shellcheck lint

* cleanup: remove extra space

* cleanup: add script indent

* cleanup: fix ci comments

* cleanup: add explanatory note

* test: fix all tests

* test: fix integration test

* test: add export for GOOGLE SA before running scripts

Co-authored-by: minherz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove associating ServiceAccount to GCE VMs
2 participants