-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement: remove SA attached to GCE #425
Conversation
* fix: explicitly enable gkeconnect API Fix test flakiness (like [1]) by explicitly enabling gkeconnect.googleapis.com [1] https://github.com/GoogleCloudPlatform/anthos-samples/actions/runs/3190598002/jobs/5205918332 * chore: fix tf list syntax * chore: fix tf formatting
* feature: add GCE VM bash scripts * cleanup: update .gitignore * cleanup: add FAQ section * cleanup: add FAQ section * cleanup: shellcheck lint * cleanup: remove extra space * cleanup: add script indent * cleanup: fix ci comments * cleanup: add explanatory note
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with a couple of nit remarks.
test/integration/abm_gce_defaults_on_editor_project/abm_gce_editor_test.go
Outdated
Show resolved
Hide resolved
* improvement: remove SA attahced to GCE * cleanup: explicitly enable gkeconnect API (#439) * fix: explicitly enable gkeconnect API Fix test flakiness (like [1]) by explicitly enabling gkeconnect.googleapis.com [1] https://github.com/GoogleCloudPlatform/anthos-samples/actions/runs/3190598002/jobs/5205918332 * chore: fix tf list syntax * chore: fix tf formatting * feature: add ABM on GCE VM bash script sample (#437) * feature: add GCE VM bash scripts * cleanup: update .gitignore * cleanup: add FAQ section * cleanup: add FAQ section * cleanup: shellcheck lint * cleanup: remove extra space * cleanup: add script indent * cleanup: fix ci comments * cleanup: add explanatory note * test: fix all tests * test: fix integration test * test: add export for GOOGLE SA before running scripts Co-authored-by: minherz <[email protected]>
Fixes #424
Description
Change summary
Service Account
used for running Terraform into the GCE VMs once they are createdRelated PRs/Issues