This repository has been archived by the owner on Nov 11, 2022. It is now read-only.
Fix InProcessPipelineRunner to handle a null subscription #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgroh
reviewed
Feb 6, 2017
| @@ -320,4 +327,14 @@ public void readManyMessages() throws IOException { | |||
| assertTrue(dataToMessageNum.isEmpty()); | |||
| reader.close(); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testNullTopic() throws Exception { | |||
There was a problem hiding this comment.
Null subscription, right? We probably also want to show that we created a subscription.
|
For verifying the subscription, is the least-bad way I can see is to make an additional factory method that includes a verifyCreateSubscription toggle. Anything nicer than that? |
|
Is this fixing the same bug as apache/beam@4406414 ? Thoughts on a more direct backport? |
|
better link: apache/beam#1817 |
|
I think this is a different issue (not present in Beam), made obsolete by
the new structure of the function in question.
…On Tue, Feb 14, 2017 at 9:31 AM, Daniel Halperin ***@***.***> wrote:
better link: apache/beam#1817 <apache/beam#1817>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#547 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACQVgeOymSRIOAwP6UwqlIR-XJhMM597ks5rceTdgaJpZM4L1p5d>
.
|
|
I don't think there's anything nicer than that, but I'm not particularly bothered (given that it's a |
|
Done, please take another look. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @tgroh