Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are Node.js nightly and v8-canary supported? #29

Closed
vsemozhetbyt opened this issue Apr 6, 2018 · 8 comments
Closed

Are Node.js nightly and v8-canary supported? #29

vsemozhetbyt opened this issue Apr 6, 2018 · 8 comments

Comments

@vsemozhetbyt
Copy link

Windows 7 x64.
Node.js 10.0.0-v8-canary-2018-04-03-635853bf03 (V8 6.7.213-node.0)
jsvu v1.1.1
Second (updating) run:

> jsvu
� jsvu v1.1.1 — the JavaScript engine Version Updater �
✔ Read OS from config: win64
✔ Read engines from config: v8
Administrator: C:\Windows\system32\cmd.exe - jsvu[6168]: src\node_contextify.cc:759: Assertion `args[1]->IsString()' failed.
 1: node::DecodeWrite
 2: node::DecodeWrite
 3: uv_loop_fork
 4: v8::internal::compiler::OperationTyper::ConvertTaggedHoleToUndefined
 5: v8::internal::compiler::CodeAssembler::TailCallBytecodeDispatch<v8::internal::compiler::Node * __ptr64,v8::internal::compiler::Node * __ptr64,v8::internal::compiler::Node * __ptr64,v8::internal::compiler::Node * __ptr64>
 6: v8::internal::compiler::CodeAssembler::TailCallBytecodeDispatch<v8::internal::compiler::Node * __ptr64,v8::internal::compiler::Node * __ptr64,v8::internal::compiler::Node * __ptr64,v8::internal::compiler::Node * __ptr64>
 7: v8::internal::compiler::CodeAssembler::TailCallBytecodeDispatch<v8::internal::compiler::Node * __ptr64,v8::internal::compiler::Node * __ptr64,v8::internal::compiler::Node * __ptr64,v8::internal::compiler::Node * __ptr64>
 8: 000000FA22B841AF
@vsemozhetbyt
Copy link
Author

Node.js 10.0.0-nightly-2018-04-03-d54f651910 (V8 6.5.254.43-node.5)

> node.10.0.0.v8-6.5.2018-04-03.nightly.exe node_modules\jsvu\cli.js
� jsvu v1.1.1 — the JavaScript engine Version Updater �
✔ Read OS from config: win64
✔ Read engines from config: v8
Administrator: C:\Windows\system32\cmd.exe - node.10.0.0.v8-6.5.2018-04-03.nightly.exe  node_modules\jsvu\cli.js[4508]: src\node_contextify.cc:759: Assertion `args[1]->IsString()' failed.
 1: node::DecodeWrite
 2: node::DecodeWrite
 3: uv_loop_fork
 4: v8::internal::interpreter::ConstantArrayBuilder::DiscardReservedEntry
 5: v8::internal::LocalEmbedderHeapTracer::RequiresImmediateWrapperProcessing
 6: v8::internal::LocalEmbedderHeapTracer::RequiresImmediateWrapperProcessing
 7: v8::internal::LocalEmbedderHeapTracer::RequiresImmediateWrapperProcessing
 8: 0000018408404281

@vsemozhetbyt
Copy link
Author

Node.js 9.11.1 (V8 6.2.414.46-node.23) is OK.

> node.09.11.1.v8-6.2.exe node_modules\jsvu\cli.js
� jsvu v1.1.1 — the JavaScript engine Version Updater �
✔ Read OS from config: win64
✔ Read engines from config: v8
✔ Found latest V8 version: v6.7.246.
✔ URL: https://storage.googleapis.com/chromium-v8/official/canary/v8-win64-rel-6.7.246.zip
✔ Download completed.
❯ Extracting…
Installing library to ~\.jsvu\engines\v8\icudtl.dat…
Installing library to ~\.jsvu\engines\v8\natives_blob.bin…
Installing library to ~\.jsvu\engines\v8\snapshot_blob.bin…
Installing binary to ~\.jsvu\engines\v8\v8.exe…
Installing wrapper script to ~\.jsvu\v8.cmd…
✔ Extraction completed.
✔ Testing completed.
✔ V8 v6.7.246 has been installed!

@mathiasbynens
Copy link
Member

Only the version in .nvmrc and any more recent stable Node.js versions are supported.

The breakage you describe seems like it would affect many more projects, and would therefore not make it to Node.js stable.

@devsnek
Copy link

devsnek commented Apr 8, 2018

evil chain is as follows: unzip -> fstream -> outdated graceful-fs -> outdated natives

@addaleax released an updated version of natives a few days ago to fix this but it won't travel up the dep chain very well in cases like this

and as a sidenote the idea of an unzip package using streaming makes me rather nervous, as zip files aren't stream safe, i would recommend switching to yauzl which properly buffers a zip file and it will drop your dependence on old deprecated packages like graceful-fs and natives

@targos
Copy link

targos commented Apr 8, 2018

You can fix this by reinstalling jsvu to get the latest version of natives.

@vsemozhetbyt
Copy link
Author

Thank you, reinstalling fixes the issue.

@vsemozhetbyt
Copy link
Author

Should the new version of jsvu be released for this update?

mathiasbynens added a commit that referenced this issue Apr 9, 2018
@mathiasbynens mathiasbynens reopened this Apr 9, 2018
@mathiasbynens
Copy link
Member

I published a new version. Thanks, everyone!

mathiasbynens added a commit that referenced this issue May 6, 2018
Avoids indirectly dependending on deprecated packages such as
`graceful-fs` and `natives`.

Ref. #29.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants