-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Are Node.js nightly and v8-canary supported? #29
Comments
Node.js > node.10.0.0.v8-6.5.2018-04-03.nightly.exe node_modules\jsvu\cli.js
� jsvu v1.1.1 — the JavaScript engine Version Updater �
✔ Read OS from config: win64
✔ Read engines from config: v8
Administrator: C:\Windows\system32\cmd.exe - node.10.0.0.v8-6.5.2018-04-03.nightly.exe node_modules\jsvu\cli.js[4508]: src\node_contextify.cc:759: Assertion `args[1]->IsString()' failed.
1: node::DecodeWrite
2: node::DecodeWrite
3: uv_loop_fork
4: v8::internal::interpreter::ConstantArrayBuilder::DiscardReservedEntry
5: v8::internal::LocalEmbedderHeapTracer::RequiresImmediateWrapperProcessing
6: v8::internal::LocalEmbedderHeapTracer::RequiresImmediateWrapperProcessing
7: v8::internal::LocalEmbedderHeapTracer::RequiresImmediateWrapperProcessing
8: 0000018408404281 |
Node.js > node.09.11.1.v8-6.2.exe node_modules\jsvu\cli.js
� jsvu v1.1.1 — the JavaScript engine Version Updater �
✔ Read OS from config: win64
✔ Read engines from config: v8
✔ Found latest V8 version: v6.7.246.
✔ URL: https://storage.googleapis.com/chromium-v8/official/canary/v8-win64-rel-6.7.246.zip
✔ Download completed.
❯ Extracting…
Installing library to ~\.jsvu\engines\v8\icudtl.dat…
Installing library to ~\.jsvu\engines\v8\natives_blob.bin…
Installing library to ~\.jsvu\engines\v8\snapshot_blob.bin…
Installing binary to ~\.jsvu\engines\v8\v8.exe…
Installing wrapper script to ~\.jsvu\v8.cmd…
✔ Extraction completed.
✔ Testing completed.
✔ V8 v6.7.246 has been installed! � |
Only the version in The breakage you describe seems like it would affect many more projects, and would therefore not make it to Node.js stable. |
evil chain is as follows: @addaleax released an updated version of natives a few days ago to fix this but it won't travel up the dep chain very well in cases like this and as a sidenote the idea of an unzip package using streaming makes me rather nervous, as zip files aren't stream safe, i would recommend switching to yauzl which properly buffers a zip file and it will drop your dependence on old deprecated packages like graceful-fs and natives |
You can fix this by reinstalling |
Thank you, reinstalling fixes the issue. |
Should the new version of |
I published a new version. Thanks, everyone! |
Avoids indirectly dependending on deprecated packages such as `graceful-fs` and `natives`. Ref. #29.
Windows 7 x64.
Node.js
10.0.0-v8-canary-2018-04-03-635853bf03
(V86.7.213-node.0
)jsvu v1.1.1
Second (updating) run:
The text was updated successfully, but these errors were encountered: