Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(legacy-javascript): drop parseInt, Array.prototype.reduce,reduceRight signals #13439

Closed
wants to merge 4 commits into from
Closed

core(legacy-javascript): drop parseInt, Array.prototype.reduce,reduceRight signals #13439

wants to merge 4 commits into from

Conversation

zloirock
Copy link

@zloirock zloirock commented Nov 29, 2021

Because of this V8 bug, core-js polyfill Array.prototype.{ reduce, reduceRight } in Chrome 80-82 -> with esmodules target - too. See core-js-compat data.


Update: Also, Number.parseInt should be polyfilled in Chakra-based Edge.


Too many polyfills should be added to this list, but I'm not very familiar with the Lighthouse architecture, so I'll just create an issue about it. See #13440.

@connorjclark
Copy link
Collaborator

Ah, that's a shame. Good catch. Thanks!

Update: Also, Number.parseInt should be polyfilled in Chakra-based Edge.

Does that refer to this part of the compat data?

https://github.com/zloirock/core-js/blob/361b0b4b264df59beb3a481023fd4635b98bd3c7/packages/core-js-compat/src/data.mjs#L824

@connorjclark connorjclark changed the title Drop Array.prototype.{ reduce, reduceRight } from legacy polyfills core(legacy-javascript): drop parseInt, Array.prototype.reduce,reduceRight signals Nov 29, 2021
@connorjclark
Copy link
Collaborator

Could you also include these changes?
image

@zloirock
Copy link
Author

zloirock commented Nov 30, 2021

Does that refer to this part of the compat data?

Yes, but not exactly. es.number.parse-int, not es.parse-int.

@connorjclark
Copy link
Collaborator

continuing here #13482

@zloirock zloirock deleted the array-reduce-polyfill branch December 10, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants