deps: update marky to latest #12440
Merged
deps: update marky to latest #12440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
May 4, 2021
| @@ -2,16 +2,17 @@ | |||
| # yarn lockfile v1 | |||
|
|
|||
|
|
|||
| debug@^2.6.8: | |||
| debug@^2.6.9: | |||
There was a problem hiding this comment.
weird that the package.json version and actual version in here got bumped in #9398 but this line didn't 🤷
adamraine
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12439 (but really just for contributors)
See nolanlawson/marky#18 for the issue in node 16 (introduced in nodejs/node#37970).
However as noted by @patrickhulce in GoogleChrome/lighthouse-ci#596 (comment),
lighthouse-loggercurrently usesmarky@^1.2.0, so any downstream project just needs to refresh their deps and they'll pick up 1.2.2.However, contributors (with a git repo checkout) are subject to our
yarn.lockfiles for dependencies, so we do need to update those for us.