Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use strict version of assert functions #201

Merged
merged 1 commit into from
May 16, 2020
Merged

test: use strict version of assert functions #201

merged 1 commit into from
May 16, 2020

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented May 16, 2020

The non-strict versions are deprecated. I've not changed the usage of equal in utils-test as the tests are replaced in #200 (which already uses the strict versions), and so would just cause a merge conflict.

patrickhulce
patrickhulce approved these changes May 16, 2020
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @G-Rath! 👍

@patrickhulce patrickhulce merged commit 88e4968 into GoogleChrome:master May 16, 2020
@G-Rath G-Rath deleted the use-strict-assert-functions branch May 16, 2020 00:44
@paulirish paulirish mentioned this pull request Jun 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@G-Rath @patrickhulce