-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API demo CLI tool #4
Conversation
const labeledMetrics = await labelMetricData(json.record.metrics); | ||
|
||
// The CWV 75%ile thresholds. | ||
const nameToCWVMap = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can we make this more resilient to threshold changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh I'm not sure. We can look at the end of the first bucket of each metric. Which is the CWV threshold. But that isn't guaranteed to be true for all time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
related GoogleChrome/web-vitals#2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At minimum, the threshold should not change before May 2021, and if it were to change (in 2021 or some other future CWV release) there'd be a coordinated effort to ensure all tools were updated accordingly.
Adds a nodejs micro library to
demo/api/
folder.This is based on the code in the demo app code in the getting-started page with some Core Web Vitals flavor mixed in via the p75 data.