Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User login #209

Merged
merged 7 commits into from
May 24, 2019
Merged

User login #209

merged 7 commits into from
May 24, 2019

Conversation

bplantico
Copy link
Collaborator

What does this PR do?

Adds completed login functionality to handle when valid or invalid credentials are provided. All tests passing.

bplantico and others added 7 commits May 23, 2019 15:57
…ster branch but not on the branch I was working on

Merge branch 'master' of github.com:GlynnisOC/little_shop_v2 into user-login
…tests passing, 100% coverage.

Co-Authored-By: Glynnis O'Connell <[email protected]>
@bplantico bplantico requested review from Mycobee and james-cape May 24, 2019 00:18
Copy link
Collaborator

@james-cape james-cape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@james-cape james-cape merged commit 46a82a9 into master May 24, 2019
@james-cape james-cape deleted the user-login branch May 24, 2019 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants