Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added SHIFT modifier to shortcut keys #73

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

samranjbari
Copy link
Contributor

No description provided.

@avanderhoorn
Copy link
Contributor

Any chance we can make it alt or cntr? I'm just thinking we will still have the same problem we had before with shift :( Thanks for you continued effort!

@samranjbari
Copy link
Contributor Author

we certainly can, but ctrl+G is a reserved in chrome as it brings up the search feature and "alt" selects the address bar. Might need to think about this some more. How concerned are you with the glimpse popup if someone is typing uppercase G

@avanderhoorn
Copy link
Contributor

Unfortunately I think its going to be more common than not :( what about shift+cntr+G?

@samranjbari
Copy link
Contributor Author

I'm starting to feel less excited about this feature, since shift+ctrl+G is a lot more use of fingers than mouse clicking on the dang hud.

@avanderhoorn
Copy link
Contributor

I get what you mean but I'm not sure how else we can do it without tripping over something... for me it still means that you don't have to reach for the mouse and I think most site/components use shift+cntr/alt for there shortcut keys (gmail as an example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants