Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HMSL optional #595

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Make HMSL optional #595

merged 2 commits into from
Jun 28, 2023

Conversation

agateau-gg
Copy link
Collaborator

Doing this should solve brew install issues on macOS.

@agateau-gg agateau-gg force-pushed the agateau/make-hmsl-optional branch from aad9160 to eeca9e3 Compare June 28, 2023 13:42
@agateau-gg agateau-gg requested a review from pierrelalanne June 28, 2023 13:42
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Merging #595 (eeca9e3) into main (7040795) will decrease coverage by 0.04%.
The diff coverage is 71.42%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
- Coverage   93.78%   93.74%   -0.04%     
==========================================
  Files         104      104              
  Lines        4808     4814       +6     
==========================================
+ Hits         4509     4513       +4     
- Misses        299      301       +2     
Flag Coverage Δ
unittests 93.74% <71.42%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ggshield/cmd/main.py 89.18% <71.42%> (-1.99%) ⬇️

@agateau-gg agateau-gg merged commit 80e013d into main Jun 28, 2023
@agateau-gg agateau-gg deleted the agateau/make-hmsl-optional branch June 28, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants