Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix patchwork naming issue on OSX #130

Merged
merged 1 commit into from
Jul 19, 2015
Merged

Fix patchwork naming issue on OSX #130

merged 1 commit into from
Jul 19, 2015

Conversation

shashi
Copy link
Collaborator

@shashi shashi commented Jul 14, 2015

related to JuliaLang/julia#9079

WTF!!!!!

@shashi shashi changed the title Possibly fix patchwork naming issue on OSX Fix patchwork naming issue on OSX Jul 14, 2015
@jiahao
Copy link
Contributor

jiahao commented Jul 14, 2015

This still doesn't fix the problem for me: (problem with precompilation)

julia> using Compose #this branch, julia release-0.3 head

julia> Compose.Patchable
ERROR: Patchable not defined

julia> Pkg.installed("Patchwork")
v"0.1.6"

julia> Compose.isinstalled("Patchwork", v"0.1.2")
true

@shashi
Copy link
Collaborator Author

shashi commented Jul 14, 2015

This is not merged yet. You need to checkout the shashi-osx-fix branch.

On Tue, Jul 14, 2015, 2:31 PM Jiahao Chen [email protected] wrote:

This still doesn't fix the problem for me:

julia> using Compose #master, julia release-0.3 head

julia> Compose.Patchable
ERROR: Patchable not defined

julia> Pkg.installed("Patchwork")
v"0.1.6"

julia> Compose.isinstalled("Patchwork", v"0.1.2")
true


Reply to this email directly or view it on GitHub
#130 (comment).

@jiahao
Copy link
Contributor

jiahao commented Jul 14, 2015

This is not merged yet. You need to checkout the shashi-osx-fix branch.

Yes, I applied this patch and it still doesn't work for me.

@jiahao
Copy link
Contributor

jiahao commented Jul 14, 2015

Ok never mind I forgot I had Compose precompiled on my release branch.

It does work for me now.

@shashi
Copy link
Collaborator Author

shashi commented Jul 14, 2015

I checked again, I did rename it properly with git. Can you check if
src/patchwork.jl isn't lurking? And it worked for Alan...

On Tue, Jul 14, 2015, 2:53 PM Jiahao Chen [email protected] wrote:

This is not merged yet. You need to checkout the shashi-osx-fix branch.

Yes, I applied this patch and i still doesn't work for me.


Reply to this email directly or view it on GitHub
#130 (comment).

@shashi
Copy link
Collaborator Author

shashi commented Jul 14, 2015

Oh.

On Tue, Jul 14, 2015, 3:10 PM Shashi Gowda [email protected] wrote:

I checked again, I did rename it properly with git. Can you check if
src/patchwork.jl isn't lurking? And it worked for Alan...

On Tue, Jul 14, 2015, 2:53 PM Jiahao Chen [email protected]
wrote:

This is not merged yet. You need to checkout the shashi-osx-fix branch.

Yes, I applied this patch and i still doesn't work for me.


Reply to this email directly or view it on GitHub
#130 (comment).

@jiahao
Copy link
Contributor

jiahao commented Jul 14, 2015

For the record, the problem is fixed so long as Compose is not precompiled. Even with this patch, the Patchable not defined error is thrown if Compose is precompiled.

@shashi
Copy link
Collaborator Author

shashi commented Jul 14, 2015

Oh wow.

On Tue, Jul 14, 2015, 3:26 PM Jiahao Chen [email protected] wrote:

For the record, the problem is fixed so long as Compose is not
precompiled. Even with this patch, the Patchable not defined error is
thrown if Compose is precompiled.


Reply to this email directly or view it on GitHub
#130 (comment).

shashi added a commit that referenced this pull request Jul 19, 2015
Fix patchwork naming issue on OSX
@shashi shashi merged commit c64e829 into master Jul 19, 2015
@shashi shashi deleted the shashi-osx-fix branch October 20, 2015 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants