feat: Support generic validation messages on inputs. #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
August 30, 2019 12:45
This reverts commit 9c47fe2.
|
Deploy preview for jobber-atlantis ready! Built with commit 90ea008 |
seanhealy
suggested changes
Sep 4, 2019
seanhealy
changed the title
seanhealy
suggested changes
Sep 5, 2019
| @@ -166,13 +186,23 @@ export const FormField = React.forwardRef( | |||
| handleValidation(); | |||
| }, [value]); | |||
|
|
|||
| let hasErrors = false; | |||
There was a problem hiding this comment.
Was just thinking we could make a little function that would return hasErrors this would let us do something like const hasErrors = areThereMessages(validations) here which would simplify reading this component and then isolate this logic into a method. Also, it's an excuse to use VSCode's fancy refactor tools!
| ## Validation message | ||
|
|
||
| You can add your own custom validation messages on a field. However, this | ||
| shouldn't replace of your server-side validation. |
There was a problem hiding this comment.
Suggested change
| shouldn't replace of your server-side validation. | |
| shouldn't replace server-side validation. |
seanhealy
changed the title
seanhealy
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
successerrorwarninfomessages on inputsAdded
Changed
Deprecated
Removed
Fixed
Security
Testing
In Atlantis we use Github's built in pull request reviews.