Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the support for test projects. Fixed tests also #22

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

SpartaDeveloper93
Copy link
Contributor

No description provided.

@SpartaDeveloper93 SpartaDeveloper93 changed the title Fixed the support for test projects. Fixed the support for test projects. Fixed tests also Oct 2, 2023
@SpartaDeveloper93
Copy link
Contributor Author

@matt-lethargic, I have raised this PR to fix existing issues

@matt-lethargic
Copy link
Member

Hi @SpartaDeveloper93 thanks for the PR. What issues is this fixing?

@SpartaDeveloper93
Copy link
Contributor Author

SpartaDeveloper93 commented Oct 2, 2023

@matt-lethargic , I was looking for a GeoJSON library to use in our application and stumbled upon this project. I saw that the last build failed, so I forked the repo.
When running the test cases locally, I noticed that one of the test cases is failing in the main branch: Can_DeserializeGeneric . It was not working and couldn't capture anything in features array
I made the change in "Feature Collection" as that one had an Inconsistent modifier declaration.
Also, TestProperties needs to be lowercase for JSON to deserialize to work. The other solution can be to actually add "JsonPropertyName" there which will work too, not sure which one would you prefer.
Also, changed csproj to just removed net462 and add netstandard 2.0 to make it consistent with main project.

@xfischer
Copy link
Member

Thanks

@xfischer xfischer merged commit c4b64c9 into GeoJSON-Net:main Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants