Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

92_boundsPostprob #104

Merged
merged 92 commits into from
Sep 30, 2024
Merged

92_boundsPostprob #104

merged 92 commits into from
Sep 30, 2024

Conversation

audreyyeoCH
Copy link
Collaborator

closes #92

Copy link
Contributor

github-actions bot commented May 24, 2024

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ----------------------------------
R/betadiff.R                59       0  100.00%
R/boundsPostprob.R          44       0  100.00%
R/boundsPredprob.R          28      28  0.00%    36-73
R/dbetabinom.R              81       3  96.30%   32, 62, 136
R/oc2.R                    162     162  0.00%    93-326
R/oc3.R                    146     146  0.00%    91-308
R/ocPostprob.R              99       4  95.96%   239-242
R/ocPostprobDist.R         109       0  100.00%
R/ocPredprob.R             182       4  97.80%   285-288
R/ocPredprobDist.R         235       3  98.72%   346-348
R/ocRctPostprobDist.R      154       4  97.40%   236-239
R/ocRctPredprobDist.R      283      55  80.57%   207-222, 225-240, 373-376, 403-421
R/plotBeta.R               103      90  12.62%   60-167
R/plotBounds.R              52      52  0.00%    33-90
R/plotDecision.R            79      79  0.00%    16-136
R/plotOc.R                  15      15  0.00%    16-36
R/postprob.R                34       1  97.06%   106
R/postprobDist.R            77       1  98.70%   204
R/predprob.R                24       0  100.00%
R/predprobDist.R           141       1  99.29%   269
R/runShinyPhase1b.R          4       4  0.00%    8-13
R/sumbetadiff.R             63      63  0.00%    24-101
R/sumTable.R                20      20  0.00%    25-48
TOTAL                     2194     735  66.50%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  --------
R/boundsPostprob.R      +13     -31  +100.00%
R/predprobDist.R         +1       0  +0.01%
TOTAL                   +14     -31  +1.64%

Results for commit: 563b8da

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@audreyyeoCH audreyyeoCH changed the title Merge remote-tracking branch 'origin/HEAD' 92_boundsPostprob May 24, 2024
Merge branch '92_boundsPostprob' of github.com:Genentech/phase1b into 92_boundsPostprob
Copy link
Contributor

github-actions bot commented May 24, 2024

Unit Tests Summary

    1 files     14 suites   1m 50s ⏱️
  117 tests   117 ✅ 0 💤 0 ❌
1 248 runs  1 248 ✅ 0 💤 0 ❌

Results for commit 563b8da.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 24, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
boundsPostProb 👶 $+0.07$ $+16$ $0$ $0$ $0$
ocPredprobDist 💔 $49.13$ $+1.36$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
boundsPostProb 👶 $+0.03$ boundsPostProb_for_beta_mixture_gives_correct_result
boundsPostProb 👶 $+0.04$ boundsPostProb_gives_correct_result

Results for commit 10d59a9

♻️ This comment has been updated with latest results.

@audreyyeoCH
Copy link
Collaborator Author

Hi @danielinteractive the checks passed ⚡️so that's great. The Roxygen Man Pages Auto Update keeps removing ocPostprob.Rd, can we squash and merge with this ? thanks again !

@danielinteractive
Copy link
Collaborator

@audreyyeoCH no we cannot just merge it without ignoring the auto-update, because that signals that there is a problem with the roxygen2 configuration. Can you please debug accordingly?

@audreyyeoCH audreyyeoCH merged commit 9fbc3ba into main Sep 30, 2024
23 checks passed
@audreyyeoCH audreyyeoCH deleted the 92_boundsPostprob branch September 30, 2024 12:55
@audreyyeoCH
Copy link
Collaborator Author

audreyyeoCH commented Oct 10, 2024

raised trouble shooting points in issue #121 check correctness again, as this test case in boundPredprob() showcased a possible workflow error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

92_boundsPostprob.R
2 participants