Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed parameterisation of Loglogistic model #275

Merged
merged 12 commits into from
Mar 1, 2024
Merged

Conversation

gowerc
Copy link
Collaborator

@gowerc gowerc commented Feb 29, 2024

Closes #273

EDIT - Accidentally merged in changes from #272 as well. This branch therefore should be merged after #272

Copy link
Contributor

github-actions bot commented Feb 29, 2024

Unit Tests Summary

  1 files   36 suites   5m 7s ⏱️
110 tests  84 ✅ 26 💤 0 ❌
801 runs  775 ✅ 26 💤 0 ❌

Results for commit 4c7631b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 29, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
SurvivalLoglogistic 💔 $0.10$ $+29.16$ $+2$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
SurvivalLoglogistic 👶 $+29.09$ SurvivalLogLogistic_can_recover_known_values
SurvivalLoglogistic 👶 $+0.09$ sim_os_loglogistic_is_consistant_with_flexsurv

Results for commit bae17ab

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 29, 2024

badge

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  --------------------------------
R/brier_score.R                  166       0  100.00%
R/DataJoint.R                     76       2  97.37%   264, 270
R/DataLongitudinal.R             119       1  99.16%   245
R/DataSubject.R                   69       1  98.55%   124
R/DataSurvival.R                  77       0  100.00%
R/defaults.R                      10       6  40.00%   18-57, 84
R/generics.R                      19       1  94.74%   49
R/JointModel.R                   122       8  93.44%   142-144, 194, 198, 240, 286, 292
R/JointModelSamples.R             54       0  100.00%
R/Link.R                          55       4  92.73%   159-162
R/LinkComponent.R                 47       5  89.36%   100, 118, 132-149
R/LongitudinalGSF.R               64       0  100.00%
R/LongitudinalModel.R             35      12  65.71%   68-83
R/LongitudinalQuantities.R        85       8  90.59%   100-107
R/LongitudinalRandomSlope.R       27       0  100.00%
R/LongitudinalSteinFojo.R         57       8  85.96%   113-135
R/Parameter.R                     14       0  100.00%
R/ParameterList.R                 42       1  97.62%   184
R/Prior.R                        236       8  96.61%   480, 576, 588-606
R/Quantities.R                   105       0  100.00%
R/settings.R                      12      12  0.00%    55-69
R/simulations_gsf.R               41       0  100.00%
R/simulations_os.R                11       0  100.00%
R/simulations_rs.R                21       0  100.00%
R/simulations_sf.R                38      38  0.00%    17-107
R/simulations.R                  101       0  100.00%
R/StanModel.R                     15       0  100.00%
R/StanModule.R                   177       6  96.61%   199-200, 242, 253, 388, 416
R/SurvivalExponential.R           10       0  100.00%
R/SurvivalLoglogistic.R           11       0  100.00%
R/SurvivalModel.R                 19       0  100.00%
R/SurvivalQuantities.R           151       6  96.03%   173-178
R/SurvivalWeibullPH.R             11       0  100.00%
R/utilities.R                    145       1  99.31%   13
R/zzz.R                            2       2  0.00%    3-12
TOTAL                           2244     130  94.21%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  -------
R/simulations_os.R        0      -5  +45.45%
R/simulations.R           0      -1  +0.99%
TOTAL                     0      -6  +0.27%

Results for commit: 4c7631b

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@gowerc
Copy link
Collaborator Author

gowerc commented Mar 1, 2024

as #272 has been merged into main this PR is now isolated again and should be easier to review :)

vignettes/statistical-specification.Rmd Outdated Show resolved Hide resolved
vignettes/statistical-specification.Rmd Show resolved Hide resolved
vignettes/statistical-specification.Rmd Outdated Show resolved Hide resolved
vignettes/statistical-specification.Rmd Outdated Show resolved Hide resolved
vignettes/statistical-specification.Rmd Outdated Show resolved Hide resolved
vignettes/statistical-specification.Rmd Outdated Show resolved Hide resolved
@gowerc gowerc merged commit ce9597a into main Mar 1, 2024
22 checks passed
@gowerc gowerc deleted the feature/loglogis branch March 1, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check Parameterisation of LogLogistic Distribution
2 participants