Address Review comments

Genentech · Mar 4, 2024 · e95d411 · e95d411
1 parent b6b3536
commit e95d411
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/R/simulations.R b/R/simulations.R
@@ -43,8 +43,8 @@ get_timepoints <- function(x) {
     "SimGroup",
     slots = c(
         n = "numeric",
-        study = "character",
-        arm = "character"
+        arm = "character",
+        study = "character"
     )
 )
 

diff --git a/tests/testthat/test-simulations.R b/tests/testthat/test-simulations.R
@@ -252,3 +252,25 @@ test_that("simulate_joint_data correctly generates an intercept per study", {
     z_score <- (ests - c(50, 70, 10)) / ests_se
     expect_true(all(abs(z_score) < qnorm(0.99)))
 })
+
+
+test_that("SimGroup() works as expected", {
+    sim_group <- SimGroup(100, "Arm-A", "Study-X")
+    expect_s4_class(sim_group, "SimGroup")
+    expect_equal(sim_group@n, 100)
+    expect_equal(sim_group@arm, "Arm-A")
+    expect_equal(sim_group@study, "Study-X")
+
+    expect_error(
+        SimGroup(c(100, 200), "Arm-A", "Study-X"),
+        regexp = "`n` must be a length 1 integer"
+    )
+    expect_error(
+        SimGroup(100, c("Arm-A", "Arm-b"), "Study-X"),
+        regexp = "`arm` must be a length 1 string"
+    )
+    expect_error(
+        SimGroup(100, "Arm-A", c("Study-X", "Study-Z")),
+        regexp = "`study` must be a length 1 string"
+    )
+})