Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PD gradient #411
PD gradient #411
Changes from all commits
11aebf8
22202ff
3c39821
4a14762
e1cb636
0c477ba
75721d6
de68241
2bdbfd1
95e1c4c
794aaaf
071d5ab
a6fba0a
44e6bc9
6a062a4
ec0f360
c080d71
f926b2c
be01452
377d36d
6515c60
0cf63fe
90cc642
151192a
aa15ae9
c0ad04d
8f6a9ba
5698174
dc78f94
6e2b5ca
a384882
15db370
270bdf8
5d98260
160c0a9
fc1c33d
423c4be
10be828
c4269ee
6b16678
1597a5b
734622d
bd7134d
dacc47d
3f1a6e6
6ae793a
74dfd10
1fd37bf
f09d7da
7e71aff
7b83812
00ac6d1
b966a15
e9b297e
979d12e
96c7e5c
2c3710f
4d93c78
f58cba6
c1c837a
e646ae2
495a912
da65cf5
5c9715c
070e08a
c977764
c07e645
5c00d2d
7ec5d7c
041dfcf
fe3fb13
3d78c67
cbba4bf
2eabdd9
783945b
af1bdca
159f869
4afd99a
b9e10ca
6f4cc44
6d9e3d3
92517a8
27f8df3
cc723a7
b9119a9
3ef78d7
9422b2b
4dd9bc6
bff442d
6e5b348
5216033
5b4d492
6da9c23
49a3d91
c319927
c0f6767
1d51876
45d8f7c
2ddce16
e0f359c
b93fbe5
370c091
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it is impossible to import say just CubicalLayer without also importing all the other tensorflow layers?
That's a possible choice, I am just wondering if that's deliberate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is not really deliberate, I just don't know how to avoid this -_-'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh? You mean what happens if you remove those 3 lines? 😕
Or are you asking how to have CubicalLayer directly in gudhi.tensorflow but still require some
import gudhi.tensorflow.cubical_layer
or something?(again, I am not asking you to change that, just discussing what we want in the end)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I wanted to be able to do
from gudhi.tensorflow import *
, but I don't know if it is possible to dofrom gudhi.tensorflow import CubicalLayer
without also importing the other two. That being said, I do not really care about this__init__
file, if there is a better, more consistent way of writing it, I'll be happy to use it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what you describe forces to load everything. To be able to load only some, I think it would need to be
from gudhi.tensorflow.cubical_layer import CubicalLayer
(there could still be a shortfrom gudhi.tensorflow.all import *
for those who want everything). I don't know if doing that would be useful, or if we should stick with loading everything, which is simpler, if a bit wasteful.